Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use expect_test for tests in src/circuit.rs and elsewhere #298

Closed
srinathsetty opened this issue Jan 24, 2024 · 0 comments
Closed

Use expect_test for tests in src/circuit.rs and elsewhere #298

srinathsetty opened this issue Jan 24, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@srinathsetty
Copy link
Collaborator

test_pp_digest in src/lib.rs uses expect_test for tests that have hardcoded constants/strings. We should apply this pattern to other tests (e.g., tests in src/circuit.rs that check the size of the verifier circuits).
@srinathsetty srinathsetty added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srinathsetty