George/permissions

[palladia]

No description provided.

[palladia]

@paulcallen, @Microsoft/omi-devs

[jeffaco]

The -w flag only checks DAC, not for read-only file system. Do you want to catch an error down at 142, or is this too unlikely? If too unlikely, then why bother checking for -w here?

[palladia]

Re-wrote function to:

createlink()
{
username=$OMI_USER

First, check if $OMI_USER's home directory is writable

if [ "x$username" != "x" ]; then
    userhome=`eval echo ~$username`
    if [ -w $userhome ]; then
        new_output="$userhome/$USER-$current_output"
        rm -rf $new_output
        mkdir $new_output
        if [ $? -eq 0 ]; then
            ln -s $new_output $current_output
        fi
    fi
fi

If that's not available, try /tmp

new_output_tmp="/tmp/$USER-$current_output"
rm -rf $new_output
mkdir $new_output
if [ $? -eq 0 ]; then
    ln -s $new_output $current_output
else
    echo "Unable to create softlink to $current_output.  Skipping..."
fi

}

[jeffaco]

Okay, I'll bite. What the heck is 932E75578CAB46E4A3EB87787B9EA40F? Perhaps a comment is in order here ...

[palladia]

No clue on why the long name was chosen.

[paulcallen]

I laughed when I saw this!

[jeffaco]

If there's no reason for this name, then it's needlessly confusing. Just pick a reasonable name, like /tmp/$USER-omi or, if that conflicts already, then /tmp/$USER-omi2 or whatever.

[palladia]

Renamed it to /tmp/omi2-$USER

[jeffaco]

Does this work on all systems (even slow ones, like HP)? Perhaps better to have a tighter loop with a long wait time, and drop out if/when the PID file disappears?

[palladia]

I've run this repeated on HP, and it seems to work. The increase in sleep here is really to give it more time before starting next test. Sometimes the next test starts up so fast that the "delete pid" operation deletes next test's omiserver pid file.

[jeffaco]

My point is it's timing sensitive. That makes it inherently risky. I don't want tests that work 90% of the time or 95% of the time, I want tests that work 100% of the time. AND: I want tests that don't take longer than they need to. So perhaps check if the PID is gone every 100 milliseconds up to 10 times or something.

[palladia]

I've created issue #172 to address this.

[paulcallen]

I think I would prefer: #include <common/Linux/sal.h>

[palladia]

Gcc command has "-I../common", if I remember correctly. I don't mind <linux/sal.h>?

[paulcallen]

yeah, I know that, but I just like things being relative to the top level. I am ok with Linux.sal.h but with angle-brackets which is used for doing search where quotes mean relative to current directory in general

[jeffaco]

Seeing <linux/sal.h> makes me think "system include file". If this is a local include file, I prefer "linux/sal.h" or something like that.

[paulcallen]

but quotes are supposed to be relative directories where as brackets are search path.

[palladia]

Originally header files within <> are supposed to be system headers, and those in quotes "" are supposed to be local ones, but since compiler doesn't enforce this, people have used them interchangeably. In OMI, I've seen both <> and "" local header files.

Technically it's "common/Linux/sal.h", but both works.

[palladia]

I've changed it to "common/Linux/sal.h".