Add amd migraphx execution provider to onnx runtime #2929

pfultz2 · 2020-01-28T23:12:45Z

Description:

This adds an initial execution provider using MIGraphX which supports the AMD ROCm stack.

As a first step, we have hardcoded the operators supported. In the future, we plan to update this to use an API from MIGraphX directly.

This also uses the C/C++ API from MIGraphX, as this will be more stable. As this hasn't been released as part of the ROCm distribution yet we build this version in the dockerfile. In the future we can switch to just pulling down the debian package from ROCm.

Motivation and Context

To support AMD GPUs in onnx runtime and take advantage of MIGraphX's graph optimizations.

msftclas · 2020-01-28T23:12:58Z

All CLA requirements met.

jywu-msft · 2020-01-29T17:33:46Z

Thanks for the contribution!
We will take a look.

jywu-msft · 2020-02-03T16:41:28Z

Would you be able to test against the models contained in the zip file?
https://github.com/microsoft/onnxruntime/blob/master/tools/ci_build/github/azure-pipelines/templates/set-test-data-variables-step.yml#L4

Those are models we test against in our CI pipelines using onnx_test_runner.

jywu-msft · 2020-02-03T17:00:29Z

why are updates showing up in the tvm and onnx-tensorrt modules?

scxiao · 2020-02-04T22:26:53Z

why are updates showing up in the tvm and onnx-tensorrt modules?

This a mismatch of the commit used by these submodules between our branch and the master branch. Fixed that.

jywu-msft · 2020-02-05T17:23:02Z

cmake/CMakeLists.txt

@@ -743,6 +744,14 @@ if (onnxruntime_USE_TENSORRT)
  endif()
 endif()

+if (onnxruntime_USE_MIGRAPHX)
+  if (WIN32)
+    message(FATAL_ERROR "MIGraphX does not support build in Windows!")


are there plans to eventually support in Windows?

We currently dont have any plans.

scxiao · 2020-03-03T23:16:25Z

Would you be able to test against the models contained in the zip file?
https://github.com/microsoft/onnxruntime/blob/master/tools/ci_build/github/azure-pipelines/templates/set-test-data-variables-step.yml#L4

Those are models we test against in our CI pipelines using onnx_test_runner.

After trying all models, MIGraphX EP can run all cases by either falling back to CPU or run correctly on MIGraphX.

…o migraphx

jywu-msft · 2020-03-30T11:03:31Z

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Win CPU x64 NoContribops CI Pipeline, Win CPU x86 CI Pipeline, Windows CPU CI Pipeline

azure-pipelines · 2020-03-30T11:04:16Z

Azure Pipelines successfully started running 9 pipeline(s).

jywu-msft · 2020-03-30T11:05:43Z

/azp run Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline

azure-pipelines · 2020-03-30T11:05:57Z

Azure Pipelines successfully started running 2 pipeline(s).

jywu-msft · 2020-04-01T11:13:35Z

/azp run MacOS CI Pipeline

azure-pipelines · 2020-04-01T11:13:45Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-05-22T01:34:13Z

Azure Pipelines successfully started running 5 pipeline(s).

jywu-msft · 2020-05-22T12:15:43Z

windows build is failing because of failing python pep8 check (which is new)
see https://github.com/microsoft/onnxruntime/blob/master/docs/Coding_Conventions_and_Standards.md#python-code-style
can you ensure any modified python files are following pep8 conventions? thanks!

…o migraphx

scxiao · 2020-05-22T20:26:36Z

windows build is failing because of failing python pep8 check (which is new)
see https://github.com/microsoft/onnxruntime/blob/master/docs/Coding_Conventions_and_Standards.md#python-code-style
can you ensure any modified python files are following pep8 conventions? thanks!

Thanks. Just fixed it, hope it can pass this time.

jywu-msft · 2020-05-23T02:40:29Z

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Win CPU x64 NoContribops CI Pipeline, Win CPU x86 CI Pipeline, Windows CPU CI Pipeline

jywu-msft · 2020-05-23T02:40:43Z

/azp run Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-mac-ci-pipeline

azure-pipelines · 2020-05-23T02:41:02Z

Azure Pipelines successfully started running 7 pipeline(s).

azure-pipelines · 2020-05-23T02:41:08Z

Azure Pipelines successfully started running 5 pipeline(s).

jywu-msft · 2020-05-24T02:00:19Z

/azp run Windows CPU CI Pipeline

azure-pipelines · 2020-05-24T02:00:31Z

Azure Pipelines successfully started running 1 pipeline(s).

jywu-msft · 2020-05-26T01:43:37Z

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Win CPU x64 NoContribops CI Pipeline, Win CPU x86 CI Pipeline

jywu-msft · 2020-05-26T01:43:49Z

/azp run Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-mac-ci-pipeline

azure-pipelines · 2020-05-26T01:44:06Z

Azure Pipelines successfully started running 6 pipeline(s).

azure-pipelines · 2020-05-26T01:44:14Z

Azure Pipelines successfully started running 5 pipeline(s).

jywu-msft · 2020-05-26T03:18:50Z

@snnn is the static analysis failure a known issue? i don't think it's due to changes in this PR

snnn · 2020-05-26T05:28:08Z

Yes. Please update the branch with the latest master

jywu-msft · 2020-05-26T11:43:43Z

@scxiao please merge latest master to fix the windows cpu CI build failure (due to static analysis failure)
I will kick off tests again. everything should pass afterwards. thanks!

…o migraphx

scxiao · 2020-05-26T13:13:13Z

@scxiao please merge latest master to fix the windows cpu CI build failure (due to static analysis failure)
I will kick off tests again. everything should pass afterwards. thanks!

Thanks for the info. I just merged that. Please try again.

jywu-msft · 2020-05-26T13:59:12Z

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Win CPU x64 NoContribops CI Pipeline, Win CPU x86 CI Pipeline

jywu-msft · 2020-05-26T13:59:22Z

/azp run Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-mac-ci-pipeline

azure-pipelines · 2020-05-26T13:59:45Z

Azure Pipelines successfully started running 6 pipeline(s).

azure-pipelines · 2020-05-26T13:59:49Z

Azure Pipelines successfully started running 5 pipeline(s).

jywu-msft · 2020-05-26T17:52:38Z

/azp run Windows CPU CI Pipeline

azure-pipelines · 2020-05-26T17:52:48Z

Azure Pipelines successfully started running 1 pipeline(s).

Add amd migraphx execution provider to onnx runtime

9cc58ad

pfultz2 requested a review from a team as a code owner January 28, 2020 23:12

merge changes from master branch

6a4a77b

jywu-msft reviewed Feb 5, 2020

View reviewed changes

rename MiGraphX to MIGraphX

90a9cd5

scxiao force-pushed the migraphx branch from dea4f2c to 90a9cd5 Compare February 5, 2020 21:29

scxiao added 6 commits February 14, 2020 15:00

merge changes from master branch

4af9ae5

remove unnecessary changes in migraphx_execution_provider.cc

f8e22a8

add migraphx EP to tests

d7ec1c5

merge changes from master branch

8fd1182

add input requests of the batchnorm operator

b59adfc

add to support an onnx operator PRelu

e2c3438

scxiao added 6 commits March 4, 2020 18:30

update migrapx dockerfile and removed one unused line

595047e

Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…

ada8076

…o migraphx

Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…

4f72bd0

…o migraphx

sync submodules with mater branch

ce5807a

fixed a small bug

3424a6e

Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…

f76d8e5

…o migraphx

scxiao added 2 commits May 22, 2020 15:24

fix python file format

36709b8

Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…

74b02b3

…o migraphx

fixed a code style issue

e0b5761

add default provider for migraphx execution provider

cff059f

Merge branch 'master' of https://github.com/Microsoft/onnxruntime int…

b340162

…o migraphx

jywu-msft approved these changes May 26, 2020

View reviewed changes

jywu-msft merged commit 7759136 into microsoft:master May 26, 2020

Add amd migraphx execution provider to onnx runtime #2929

Add amd migraphx execution provider to onnx runtime #2929

Conversation

pfultz2 commented Jan 28, 2020 • edited Loading

msftclas commented Jan 28, 2020 • edited Loading

jywu-msft commented Jan 29, 2020

jywu-msft commented Feb 3, 2020

jywu-msft commented Feb 3, 2020

scxiao commented Feb 4, 2020

jywu-msft Feb 5, 2020

Choose a reason for hiding this comment

pfultz2 Feb 7, 2020

Choose a reason for hiding this comment

scxiao commented Mar 3, 2020

jywu-msft commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

jywu-msft commented Mar 30, 2020

azure-pipelines bot commented Mar 30, 2020

jywu-msft commented Apr 1, 2020

azure-pipelines bot commented Apr 1, 2020

azure-pipelines bot commented May 22, 2020

jywu-msft commented May 22, 2020

scxiao commented May 22, 2020

jywu-msft commented May 23, 2020

jywu-msft commented May 23, 2020

azure-pipelines bot commented May 23, 2020

azure-pipelines bot commented May 23, 2020

jywu-msft commented May 24, 2020

azure-pipelines bot commented May 24, 2020

jywu-msft commented May 26, 2020

jywu-msft commented May 26, 2020

azure-pipelines bot commented May 26, 2020

azure-pipelines bot commented May 26, 2020

jywu-msft commented May 26, 2020

snnn commented May 26, 2020

jywu-msft commented May 26, 2020

scxiao commented May 26, 2020

jywu-msft commented May 26, 2020

jywu-msft commented May 26, 2020

azure-pipelines bot commented May 26, 2020

azure-pipelines bot commented May 26, 2020

jywu-msft commented May 26, 2020

azure-pipelines bot commented May 26, 2020

pfultz2 commented Jan 28, 2020 •

edited

Loading

msftclas commented Jan 28, 2020 •

edited

Loading