Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Smaller crypto build to support SQLCipher #32

Closed
brodycj opened this issue Jul 5, 2016 · 2 comments
Closed

Smaller crypto build to support SQLCipher #32

brodycj opened this issue Jul 5, 2016 · 2 comments

Comments

@brodycj
Copy link

brodycj commented Jul 5, 2016

With help from https://github.com/sgrebnov/OpenSSL-WinRT-build along with the fix to ms/setVSvars.bat I was able to build OpenSSL and test it with SQLCipher on Windows 8.1, Windows Phone 8.1, and Windows 10 for storesafe/cordova-sqlcipher-adapter#30. However the build for each CPU target is over 12MB (over 13MB for x64).

But SQLCipher only needs the equivalent of the libcrypto.so part. Not only would this be a smaller build it would be less likely to contain major security vulnerabilities. For example, SQLCipher was completely unaffected by the Heartbleed vulnerability: https://www.zetetic.net/blog/2014/4/10/heartbleed-security-statement-for-sqlcipher.html

It would be great if someone would have a chance to look at this issue or perhaps just give some pointers.

@khouzam
Copy link

khouzam commented Jul 20, 2016

Hi @brodybits,

Looking at the build script, you're already using the static library which should only include the portions of the code that are invoked in the code that link with them. The size of the library being 12 or 13MB is not an indication of the code that will be part of the final linked project, the static library also contains all the symbol information, which will be discarded in the final executable/dll or moved to a PDB file.

I would look at the size of the final executable as an indicator, not the size of the static library.

@brodycj
Copy link
Author

brodycj commented Dec 5, 2016

Closing for now, will try this later.

@brodycj brodycj closed this as completed Dec 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants