Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal]: Deprecate config.rootDir, pass empty string into the merger. #29768

Closed
pavelfeldman opened this issue Mar 1, 2024 · 1 comment
Closed

[Internal]: Deprecate config.rootDir, pass empty string into the merger. #29768

pavelfeldman opened this issue Mar 1, 2024 · 1 comment
Assignees
@yury-s
Labels
v1.45

Comments

@pavelfeldman
Copy link
Member

Deprecate config.rootDir as it has no semantics post-merge.
@dgozman dgozman added v1.44 and removed v1.43 labels Mar 25, 2024
@yury-s
Copy link
Member

yury-s commented Mar 29, 2024

Discussion notes:

  • document FullConfig
    • split FullConfig to TestFullConfig, FullConfig
  • stop serializing top level config fields, move them to the project level instead
  • switch local reporters code to use only project level fields
  • introduce configName property (set globally, available on FullProject only)
  • introduce explicit global rootDir which will be replaced by configName in the final reports

yury-s added a commit to yury-s/playwright that referenced this issue Apr 2, 2024
@yury-s
chore: remove overides for type and status
206486e 
Reference microsoft#29768
yury-s added a commit to yury-s/playwright that referenced this issue Apr 2, 2024
@yury-s
chore: remove overides for type and status
a4e47e9 
Reference microsoft#29768
@yury-s yury-s mentioned this issue Apr 2, 2024
Merged
yury-s added a commit that referenced this issue Apr 3, 2024
@yury-s
chore: remove overrides for type and status (#30211)
63f876a 
Reference #29768
This was referenced Apr 3, 2024
Merged
Merged
yury-s added a commit to yury-s/playwright that referenced this issue Apr 3, 2024
@yury-s
chore: get rid of config and project inheritance
dd54d8a 
Reference microsoft#29768
yury-s added a commit that referenced this issue Apr 3, 2024
@yury-s
chore: move implementation of Config and Project to TestConfig and Te…
5c5f0d7 
…stProject (#30212)

Reference #29768
@yury-s yury-s mentioned this issue Apr 5, 2024
Merged
yury-s added a commit that referenced this issue Apr 5, 2024
@yury-s
chore: remove usage of configFile from junit reporter (#30273)
9e89f29 
Reference #29768
yury-s added a commit to yury-s/playwright that referenced this issue Apr 6, 2024
@yury-s
chore: read config file location from url params in ui mode
36a5f68 
Reference microsoft#29768
@yury-s yury-s mentioned this issue Apr 6, 2024
Closed
yury-s added a commit to yury-s/playwright that referenced this issue Apr 6, 2024
@yury-s
chore: read config file location from url params in ui mode
72edf84 
Reference microsoft#29768
@yury-s yury-s mentioned this issue Apr 6, 2024
Merged
yury-s added a commit that referenced this issue Apr 6, 2024
@yury-s
chore: resolve config location earlier (#30275)
3e03c80 
Reference #29768
yury-s added a commit to yury-s/playwright that referenced this issue Apr 22, 2024
@yury-s
chore: generate globalTimeout and maxFailures errors in runner
9996fb7 
Reference microsoft#29768
@yury-s yury-s mentioned this issue Apr 22, 2024
Merged
yury-s added a commit that referenced this issue Apr 22, 2024
@yury-s
chore: generate globalTimeout and maxFailures errors in runner (#30467)
1d786c8 
Generate 'global timeout' and 'max failures' errors in the runner. Avoid
reading `config.globalTimeout` and `config.maxFailures` in the base
reporters.

Reference #29768
@yury-s yury-s added v1.45 and removed v1.44 labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yury-s yury-s

Labels
v1.45
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pavelfeldman @yury-s @dgozman