chore: read config file location from url params in ui mode #30274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
force-pushed
the
config-file-in-ui-mode
branch
from
36a5f68
to
72edf84
Compare
pavelfeldman
reviewed
Apr 6, 2024
| @@ -411,8 +409,8 @@ class TestServerDispatcher implements TestServerInterface { | |||
| } | |||
|
|
|||
| export async function runUIMode(configFile: string | undefined, options: TraceViewerServerOptions & TraceViewerRedirectOptions): Promise<reporterTypes.FullResult['status'] | 'restarted'> { | |||
| return await innerRunTestServer(configFile, options, async (server: HttpServer, cancelPromise: ManualPromise<void>) => { | |||
| await installRootRedirect(server, [], { ...options, webApp: 'uiMode.html' }); | |||
| return await innerRunTestServer(configFile, options, async (server: HttpServer, cancelPromise: ManualPromise<void>, configLocation: ConfigLocation) => { | |||
There was a problem hiding this comment.
nit: resolve configFile explicitly instead of fetching it back via the callback
| @@ -80,9 +79,8 @@ export const FiltersView: React.FC<{ | |||
| const copy = new Map(projectFilters); | |||
| copy.set(projectName, !copy.get(projectName)); | |||
| setProjectFilters(copy); | |||
| const configFile = testModel?.config?.configFile; | |||
There was a problem hiding this comment.
It is safe to use testModel.config.configFile - it will always be there in the UI mode scenario.
Test results for "tests 1"3 flaky26882 passed, 618 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #29768