Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite/Wall Collision Event Repeated #1242

Closed
mileswatson opened this issue Aug 26, 2019 · 0 comments · Fixed by microsoft/pxt-common-packages#966
Closed

Sprite/Wall Collision Event Repeated #1242

mileswatson opened this issue Aug 26, 2019 · 0 comments · Fixed by microsoft/pxt-common-packages#966
Assignees
Labels
api bug Something isn't working next-release p2

Comments

@mileswatson
Copy link

mileswatson commented Aug 26, 2019

Describe the bug
When a sprite collides squarely with a wall tile, the "on sprite of kind ___ hits wall ___" block is called twice.

To Reproduce

  1. Replicate this image in MakeCode Arcade
  2. Notice that the score is increased twice each time the sprite collides with the green block. This happens in all four directions, as long as the sprite is directly in line with the tile.

Expected behavior
The score should only increase once per collision - the collision event should only be called once.

Demo

Desktop (please complete the following information):

  • Windows 10
  • Chrome, Firefox
  • Arcade 0.14.3, MakeCode 5.21.6

It is very difficult to debug, and so could be off-putting to younger students with little understanding of collision detection.

@mileswatson mileswatson changed the title Sprite/Wall Collision Detection repeate Sprite/Wall Collision Event Repeated Aug 26, 2019
@abchatra abchatra added bug Something isn't working p2 next-release api labels Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Something isn't working next-release p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants