Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The simulator in the full documentation page is cut off #5262

Open
Sheila111 opened this issue Jun 19, 2023 · 2 comments
Open

The simulator in the full documentation page is cut off #5262

Sheila111 opened this issue Jun 19, 2023 · 2 comments

Comments

@Sheila111
Copy link

Describe the bug
The simulator in the full documentation page is cut off

Steps to reproduce the behavior

  1. Navigate to https://makecode.microbit.org/beta#
  2. Games---->Magic Button Trick----->Show Instructions
  3. Scroll down the documentation to step1 and click Run

Actual behavior
The simulator in the full documentation page is cut off

Expect behavior
The simulator in the full documentation page shows completely

Screenshot
image

Additional context
1.OS: Windows11
2.makecode.microbit.org version: 6.0.8
3.Microsoft MakeCode version: 9.0.6

@microbit-matt-hillsdon
Copy link
Contributor

microbit-matt-hillsdon commented Jun 22, 2023

I think there's a general problem with the simulator embed and this documentation bug is just one case.

If you:

  1. Share a project
  2. Copy the simulator embed code
  3. Paste into a HTML file

Then you see a similar cut off simulator.

Looking at the HTML, the padding-based aspect ratio box for the iframe itself looks right, but the aspect ratio box around the nested sim iframe looks wrong.

In v6 MakeCode you get:

image

in v5, which works, you get this, which matches the iframe ratio:

image

@v-katherine
Copy link

v-katherine commented Mar 15, 2024

This bug also reproduced in below documentation page:
Games->Salute->Show Instructions, Games->Karel the LED->Show Instructions, Games->Crashy bird->Show Instructions,

Radio Games->Fireflies->Show Instructions, Radio Games->Red Light Green Light->Show Instructions, Radio Games->Voting Machine->Show Instructions, Radio Games->Rock Paper Scissors Teams->Show Instructions,Radio Games->Micro: Coin->Show Instructions, Radio Games->Infection->Show Instructions, Radio Games->Best Friends->Show Instructions,

Fashion->Name badge->Show Instructions

Music->Jonny's Bird->Show Instructions

Toys->Robot Unicorn->Show Instructions, Toys->Rotary Dial Radio Hack->Show Instructions

Science->Timing Gates->Show Instructions

The below web page also reproduced this issue:
https://makecode.microbit.org/projects/soil-moisture/code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants