-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Russian translations #7441
Comments
That's great, thanks for offering. Yes, please create a pull request. These strings were provided by the pylance team. I don't know how they were created, but I suspect it was through automation rather than human translators. |
I have a small question about terminology in error messages:
Sometimes "Format string literals (f-strings)" is used, and sometimes it's just "f-strings". Maybe it'd be better to just call them |
Yeah, there are small inconsistencies in the error messages — a consequence of them being added piecemeal over multiple years. Use your best judgement when translating. |
I greatly appreciate your willingness to contribute improved Russian strings. Currently the source of truth for our loc strings is the Microsoft loc team's repo which is not publicly accessible. If we check in loc changes in Pyright they will be overwritten the next time we get an update from the loc team. We have an internal issue tracking the need to improve this situation. We'll need some way to merge changes from the community and from the loc team. I'll prioritize thinking about how to best solve this. In the meantime, my suggestion would be to create a PR but to not merge it until we have a plan. As a side note, I'm not sure why the strings we're getting from the Microsoft loc team are so poor. Perhaps because the translators are language experts but not programmers. |
Just to be clear, I didn't mean that all the translations are wrong/bad: most of the time it does convey what error is happening. But sometimes it uses terms inconsistently or uses a weird translation for a particular term Translating technical stuff is not easy, especially if you're not an expert in the tool the strings are for 😺 |
I think the best approach is for me to submit a bug against our loc team that includes all of your suggested changes. There is a form where external users can submit loc feedback directly, but it will be easier for us to track the status of your changes if we file a bug directly. In the bug I'll need to provide the string id, current translation, and preferred translation of each string that you want to change, so opening a PR may still be the simplest approach. I can copy all of the info I need from there and then close the PR. |
Closing this issue since there's nothing actionable beyond submitting the form as suggested above. |
@erictraut in #7439 wrote:
I looked through the Russian translation strings and can confirm that a lot of them can be confusing. For example:
I would like to work on this and improve these translations (I'm a native speaker). Should I make a pull request?
The text was updated successfully, but these errors were encountered: