Support focusable, Yellowbox on acceptsKeyboardFocus #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#498 This change adds support for the "focusable" property present in upstream RN, along with react-native-windows and NetUI. We need to reconcile this against the existing acceptsKeyboardFocus property. This is tricky since its usage was untyped. We follow the same strategy as react-native-windows for this. 1. Usages of acceptsKeyboardFocus will continue to work, but will yellowbox 2. Components will prefer to use focusable, and Touchables with slightly different semantics will prefer focusable semantics when present acceptsKeyboardFocus will redbox in RNW 0.64 instead of yellowbox, but this change should allow xplat code to use focusable and not be effected by that. Validated setting a view to focusable is propagated, and that acceptsKeyboardFocus is propagated with a yellowbox.
NickGerleman
commented
Nov 18, 2020
|
Need to fix prettier formatting stuff. Will take a look at what's going on with the podfile lock. |
HeyImChris
approved these changes
Nov 18, 2020
|
Need to remove focusable from the TouchableHighlight snapshot. This looks expected though, since upstream behavior (differing from aceptsKeyboardFocus) is to not set the View to be focusable without an onPress handler, with the snapshot test doesn't seem to provide. |
|
And RCTSinglelineTextInputView snaps already had focusable it looks like 馃槃 . |
rectified95
approved these changes
Nov 19, 2020
|
/azp run |
|
No pipelines are associated with this pull request. |
|
馃殌 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fixes #498
This change adds support for the "focusable" property present in upstream RN, along with react-native-windows and NetUI. We need to reconcile this against the existing acceptsKeyboardFocus property. This is tricky since its usage was untyped. We follow the same strategy as react-native-windows for this.
acceptsKeyboardFocus will redbox in RNW 0.64 instead of yellowbox, but this change should allow xplat code to use focusable and not be effected by that.
Changelog
[macOS] [Added] - Support focusable, Yellowbox on acceptsKeyboardFocus
Test Plan
Validated setting a view to focusable is propagated, and that setting a view to acceptsKeyboardFocus works but triggers a yellowbox. More fine-grained tests for Touchable were done with the same changes in react-native-windows.
Microsoft Reviewers: Open in CodeFlow