Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow users to enable Flipper #121

Merged
merged 1 commit into from
Jun 18, 2020
Merged

fix: Allow users to enable Flipper #121

merged 1 commit into from
Jun 18, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 16, 2020

Resolves #112

To test these changes, bump to 0.62 and enable Flipper:

diff --git a/example/android/gradle.properties b/example/android/gradle.properties
index 08bd26e..699258c 100644
--- a/example/android/gradle.properties
+++ b/example/android/gradle.properties
@@ -1,3 +1,5 @@
 # These properties are required to enable AndroidX for the test app.
 android.useAndroidX=true
 android.enableJetifier=true
+
+FLIPPER_VERSION=0.33.1
diff --git a/example/ios/Podfile b/example/ios/Podfile
index 59f8153..512a835 100644
--- a/example/ios/Podfile
+++ b/example/ios/Podfile
@@ -2,6 +2,7 @@ require_relative '../node_modules/react-native-test-app/test_app.rb'

 workspace 'Example.xcworkspace'

+use_flipper!
 use_test_app! do |target|
   target.tests do
     pod 'Example-Tests', :path => '..'
diff --git a/example/package.json b/example/package.json
index f245bf9..80824e0 100644
--- a/example/package.json
+++ b/example/package.json
@@ -17,9 +17,8 @@
   "devDependencies": {
     "@babel/core": "^7.0.0",
     "mkdirp": "^0.5.1",
-    "react": "16.9.0",
-    "react-native": "0.61.5",
-    "react-native-macos": "0.61.39",
+    "react": "16.11.0",
+    "react-native": "0.62.2",
     "react-native-test-app": "../"
   }
 }

@tido64 tido64 self-assigned this Jun 16, 2020
@tido64 tido64 force-pushed the tido/enable-flipper branch 8 times, most recently from bb824d6 to c555c2d Compare June 18, 2020 00:17
@tido64 tido64 marked this pull request as ready for review June 18, 2020 06:30
@tido64 tido64 requested a review from alloy June 18, 2020 06:30
android/app/build.gradle Show resolved Hide resolved
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to not default to setting use_flipper to true? In the context of a test application, I would assume defaulting to making it as debuggable as possible would be a goal?

Otherwise the changes look good to me 👌

@sweggersen
Copy link
Member

Is there a reason to not default to setting use_flipper to true? In the context of a test application, I would assume defaulting to making it as debuggable as possible would be a goal?

I think it's because we need RN 0.62 for it to work.

@tido64
Copy link
Member Author

tido64 commented Jun 18, 2020

Is there a reason to not default to setting use_flipper to true? In the context of a test application, I would assume defaulting to making it as debuggable as possible would be a goal?

I think it's because we need RN 0.62 for it to work.

That said, I think it still makes sense to enable it by default if you're on >= 0.62. I've opened an issue here: #124.

Thanks for reviewing, everyone. ❤️

@tido64 tido64 merged commit b3fe351 into master Jun 18, 2020
@tido64 tido64 deleted the tido/enable-flipper branch June 18, 2020 10:42
@tido64
Copy link
Member Author

tido64 commented Jun 18, 2020

🎉 This PR is included in version 0.1.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alloy
Copy link
Member

alloy commented Jun 18, 2020

Got it, makes sense. Thanks for the follow-up issue! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enabling Flipper
3 participants