-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow users to enable Flipper #121
Conversation
bb824d6
to
c555c2d
Compare
c555c2d
to
6bb959c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to not default to setting use_flipper
to true
? In the context of a test application, I would assume defaulting to making it as debuggable as possible would be a goal?
Otherwise the changes look good to me 👌
I think it's because we need RN 0.62 for it to work. |
That said, I think it still makes sense to enable it by default if you're on >= 0.62. I've opened an issue here: #124. Thanks for reviewing, everyone. ❤️ |
🎉 This PR is included in version 0.1.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Got it, makes sense. Thanks for the follow-up issue! 🙏 |
Resolves #112
To test these changes, bump to 0.62 and enable Flipper: