Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: declare support for 0.74 #1863

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: declare support for 0.74 #1863

merged 2 commits into from
Mar 19, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Feb 21, 2024 •
edited

Description

Declare support for react-native@0.74

Status of 74 is here: https://github.com/orgs/reactwg/projects/5

Resolves #1656.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run test:matrix 0.74

Screenshots

Configuration JSC Hermes Fabric Fabric + Hermes
Android n/a Screenshot-Android-hermes n/a Screenshot-Android-hermes-fabric-concurrent
iOS Screenshot-iOS Screenshot-iOS-hermes Screenshot-iOS-fabric-concurrent Screenshot-iOS-hermes-fabric-concurrent

@tido64
Copy link
Member Author

tido64 commented Feb 21, 2024 •
edited

0.74.0-rc.0

@tido64 tido64 force-pushed the tido/0.74 branch 4 times, most recently from 5854078 to 8208325 Compare February 27, 2024 13:11
@tido64
Copy link
Member Author

tido64 commented Feb 27, 2024 •
edited

0.74.0-rc.1

@tido64 tido64 force-pushed the tido/0.74 branch 3 times, most recently from 4cb7371 to 73f8023 Compare February 29, 2024 12:05
@tido64
Copy link
Member Author

tido64 commented Mar 6, 2024 •
edited

0.74.0-rc.2/-rc.3/-rc.4

npm run test:matrix 0.74 completes successfully

@tido64 tido64 force-pushed the tido/0.74 branch 5 times, most recently from 974f5cf to f47801f Compare March 15, 2024 09:59
@tido64 tido64 marked this pull request as ready for review March 18, 2024 17:48
@tido64 tido64 requested a review from kelset as a code owner March 18, 2024 17:48
kelset
kelset approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the script locally, all ✅

I think that given the trajectory of the last RCs that have all worked out just fine, we can assume that it's relatively stable and we should be fine going ahead and merging this ahead of 0.74.0

@tido64 tido64 merged commit 319764b into trunk Mar 19, 2024
30 checks passed
@tido64 tido64 deleted the tido/0.74 branch March 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for react-native 0.74
2 participants
@tido64 @kelset