Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74.0-rc.0] Specs are generated but not correctly linked to appmodules #43145

Closed
tido64 opened this issue Feb 22, 2024 · 4 comments
Closed
Assignees
Labels
Bug 💻CLI p: Microsoft Partner: Microsoft Partner Resolution: Fixed A PR that fixes this issue has been merged. Resolution: PR Submitted A pull request with a fix has been provided. Type: Upgrade Issue Issues reported from upgrade issue form

Comments

@tido64
Copy link
Collaborator

tido64 commented Feb 22, 2024

Old Version

0.73.0

New Version

0.74.0-rc.0

Description

In 0.74.0-rc.0, specs are generated but not correctly linked to appmodules:

  /~/android/app/build/generated/rncli/src/main/jni/rncli.cpp:10:10: fatal error: 'RNWWebStorageSpec.h' file not found
  #include <RNWWebStorageSpec.h>
           ^~~~~~~~~~~~~~~~~~~~~
  1 error generated.

Bisecting nightlies, I found that the first build to fail is 0.74.0-nightly-20240220-e9351f0f8. The one before that, 0.74.0-nightly-20240219-28da7f9f5, builds fine.

Steps to reproduce

git clone https://github.com/microsoft/react-native-test-app.git
cd react-native-test-app
npm run set-react-version 0.74 -- --core-only
yarn
cd example/android
sed -i '' 's/#newArchEnabled/newArchEnabled/' gradle.properties
./gradlew assembleDebug

Affected Platforms

Runtime - Android, Build - MacOS

Output of npx react-native info

n/a

Stacktrace or Logs

n/a

Reproducer

https://github.com/microsoft/react-native-test-app

Screenshots and Videos

No response

@tido64 tido64 added Needs: Triage 🔍 Type: Upgrade Issue Issues reported from upgrade issue form labels Feb 22, 2024
@github-actions github-actions bot added Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Feb 22, 2024
Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@tido64
Copy link
Collaborator Author

tido64 commented Feb 22, 2024

cc @cortinico

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Feb 22, 2024
@cortinico cortinico self-assigned this Feb 22, 2024
@cortinico
Copy link
Contributor

Thanks for reporting this @tido64
Fix is here:

This requires a bump of the CLI on the 0.74 branch.

BTW for the future:
This:

sed -i '' 's/#newArchEnabled/newArchEnabled/' gradle.properties
./gradlew assembleDebug

can be just this:

./gradlew  assembleDebug -PnewArchEnabled=true

@cortinico cortinico added Resolution: PR Submitted A pull request with a fix has been provided. 💻CLI Bug and removed Needs: Triage 🔍 Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Attention Issues where the author has responded to feedback. labels Feb 22, 2024
@cortinico
Copy link
Contributor

Fixed in RC1 👍

@cortinico cortinico added the Resolution: Fixed A PR that fixes this issue has been merged. label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 💻CLI p: Microsoft Partner: Microsoft Partner Resolution: Fixed A PR that fixes this issue has been merged. Resolution: PR Submitted A pull request with a fix has been provided. Type: Upgrade Issue Issues reported from upgrade issue form
Projects
None yet
Development

No branches or pull requests

3 participants