Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Add support for react-native-macos v0.62 #197

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 25, 2020

Test Plan

  1. Apply the patch below
  2. Build Example app
diff --git a/example/package.json b/example/package.json
index 0bbefcf..d135952 100644
--- a/example/package.json
+++ b/example/package.json
@@ -17,9 +17,9 @@
   "devDependencies": {
     "@babel/core": "^7.0.0",
     "mkdirp": "^0.5.1",
-    "react": "16.9.0",
-    "react-native": "0.61.5",
-    "react-native-macos": "0.61.39",
+    "react": "16.11.0",
+    "react-native": "0.62.2",
+    "react-native-macos": "0.62.0-prerelease.8",
     "react-native-test-app": "../"
   }
 }
diff --git a/package.json b/package.json
index 3516f17..0eaf339 100644
--- a/package.json
+++ b/package.json
@@ -33,9 +33,9 @@
   "dependencies": {
     "@babel/core": "^7.0.0",
     "@babel/runtime": "^7.0.0",
-    "@react-native-community/cli": "^3.0.0",
-    "@react-native-community/cli-platform-android": "^3.0.0",
-    "@react-native-community/cli-platform-ios": "^3.0.0",
+    "@react-native-community/cli": "^4.5.1",
+    "@react-native-community/cli-platform-android": "^4.5.1",
+    "@react-native-community/cli-platform-ios": "^4.5.0",
     "chalk": "^1.1.3",
     "plop": "^2.6.0"
   },
@@ -54,9 +54,9 @@
     "eslint-plugin-prettier": "^3.1.4",
     "eslint-plugin-react": "^7.20.3",
     "prettier": "2.0.5",
-    "react": "16.9.0",
-    "react-native": "0.61.5",
-    "react-native-macos": "0.61.39",
+    "react": "16.11.0",
+    "react-native": "0.62.2",
+    "react-native-macos": "0.62.0-prerelease.8",
     "semantic-release": "^17.0.0",
     "suggestion-bot": "^1.0.0"
   },

@tido64 tido64 added the platform: macOS This affects macOS label Aug 25, 2020
@tido64 tido64 requested review from alloy and tom-un August 25, 2020 20:58
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀


def try_pod(name, podspec, project_root)
pod name, :podspec => podspec if File.exist?(File.join(project_root, podspec))
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming my understanding; this helper exists in order to support the same RN version numbers but for different platforms with differing pods, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. In react-native-macos, Folly was renamed RCT-Folly. This hasn't been upstreamed yet. react-native-macos also bundles boost-for-react-native.podspec. iOS doesn't. It would be nice if we can remove this function the future 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alloy alloy merged commit e73a4d8 into master Aug 26, 2020
@alloy alloy deleted the tido/rn-macos-62 branch August 26, 2020 11:06
@tido64
Copy link
Member Author

tido64 commented Aug 26, 2020

🎉 This PR is included in version 0.1.37 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS This affects macOS released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants