Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): fix type mismatch DeveloperSettings? vs DeveloperSettings #1967

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix(android): fix type mismatch DeveloperSettings? vs DeveloperSettings #1967

merged 1 commit into from
Apr 15, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 15, 2024

Description

Fix type mismatch DeveloperSettings? vs DeveloperSettings

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version nightly
yarn
cd example/android
./gradlew assembleDebug

@tido64 tido64 requested a review from kelset as a code owner April 15, 2024 06:59
@github-actions github-actions bot added the platform: Android This affects Android label Apr 15, 2024
@tido64 tido64 mentioned this pull request Apr 15, 2024
Open
15 tasks
kelset
kelset approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and locally works - :shipit:

@tido64 tido64 merged commit a18a69a into trunk Apr 15, 2024
30 checks passed
@tido64 tido64 deleted the tido/android/fix-devsettings-nullable branch April 15, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tido64 @kelset