Update project file with correct React Native source directory #2091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to run the test app in the async-storage repo on 0.74 and was facing the following error:
I was getting the error on both the ReactNativeAsyncStorage and ReactTestApp project file. The cause of the error was that the
JSI_SourcePath
variable in both of the projects was not being recognized, due to theReactNativeDir
not being defined, which caused the JSI error.Platforms affected
Test plan
I was able to apply the fix to the ReactNativeAsyncStorage project file, but could not fix the ReactTestApp project file locally as it was generated from the RNTA package - this is the fix that should resolve the issue. I was able to build the ReactTestApp in the example directory of the repo successfully after making this change.