Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project file with correct React Native source directory #2091

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Yajur-Grover
Copy link
Contributor

@Yajur-Grover Yajur-Grover commented Jun 18, 2024

Description

I tried to run the test app in the async-storage repo on 0.74 and was facing the following error:

× Building Solution
× Build failed with message 7:10>C:\new-account-repos\async-storage\packages\default-storage\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiAbiApi.h(11,10): error C1083: Cannot open include file: 'jsi/jsi.h': No such file or directory [C:\new-account-repos\async-storage\packages\default-storage\windows\ReactNativeAsyncStorage\ReactNativeAsyncStorage.vcxproj]. Check your build configuration.
Command failed with error MSBuildError: 7:10>C:\new-account-repos\async-storage\packages\default-storage\node_modules\react-native-windows\Microsoft.ReactNative.Cxx\JSI\JsiAbiApi.h(11,10): error C1083: Cannot open include file: 'jsi/jsi.h': No such file or directory [C:\new-account-repos\async-storage\packages\default-storage\windows\ReactNativeAsyncStorage\ReactNativeAsyncStorage.vcxproj]

I was getting the error on both the ReactNativeAsyncStorage and ReactTestApp project file. The cause of the error was that the JSI_SourcePath variable in both of the projects was not being recognized, due to the ReactNativeDir not being defined, which caused the JSI error.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

I was able to apply the fix to the ReactNativeAsyncStorage project file, but could not fix the ReactTestApp project file locally as it was generated from the RNTA package - this is the fix that should resolve the issue. I was able to build the ReactTestApp in the example directory of the repo successfully after making this change.

@Yajur-Grover Yajur-Grover changed the title update project file with correct React Native source directory Update project file with correct React Native source directory Jun 18, 2024
@Yajur-Grover Yajur-Grover marked this pull request as ready for review June 18, 2024 16:44
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@tido64 tido64 merged commit aa8e8d0 into microsoft:trunk Jun 18, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants