Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): use upstream autolink script #303

Merged
merged 1 commit into from Apr 7, 2021

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 2, 2021

Description

The issue that lead us to forking native_modules.gradle from @react-native-community/cli-platform-android, may have been fixed in v4.4.0.

Resolves #31.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

This was tested in lpc-android and seemed to work fine. The diff in the generated file:

diff --git a/~/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java b/~/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java
index f944cc949a0..5b6436f943b 100644
--- a/~/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java
+++ b/~/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java
@@ -11,9 +11,6 @@ import com.facebook.react.shell.MainReactPackage;
 import java.util.Arrays;
 import java.util.ArrayList;
 
-import com.microsoft.reacttestapp.BuildConfig;
-import com.microsoft.reacttestapp.R;
-
 // @react-native-community/netinfo
 import com.reactnativecommunity.netinfo.NetInfoPackage;
 // react-native-webview

The issue that lead us to forking `native_modules.gradle` from
`@react-native-community/cli-platform-android`, may have been fixed in
[v4.4.0](https://github.com/react-native-community/cli/releases/tag/v4.4.0).
@tido64 tido64 added the platform: Android This affects Android label Apr 2, 2021
@arazabishov
Copy link
Member

This is awesome! Since test apps in this repo do not consume native modules, we will have to validate this change in Midgard before merging.

@tido64
Copy link
Member Author

tido64 commented Apr 3, 2021

we will have to validate this change in Midgard before merging.

I've tested this locally. I would really appreciate it if you could validate it some time next week. ❤️

@arazabishov
Copy link
Member

arazabishov commented Apr 7, 2021

I ran a smoke test against this branch in Midgard and the inner dev loop seems to be working fine 👍🏼

@tido64 tido64 merged commit 4929c48 into master Apr 7, 2021
@tido64 tido64 deleted the tido/android-native-modules branch April 7, 2021 14:35
@github-actions
Copy link

github-actions bot commented Apr 7, 2021

🎉 This PR is included in version 0.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tido64 tido64 mentioned this pull request Oct 17, 2021
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriding the package name when auto-linking on Android
2 participants