Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix pod install causing duplicates #914

Merged
merged 1 commit into from May 23, 2022
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 23, 2022

Description

When building react-native from main, we invoke yarn under react-native/packages/react-native-codegen to prepare it. This also installs dependencies, causing duplicates to appear and fails our tests.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run set-react-version main
yarn
cd example
pod install --project-directory=ios
yarn jest

When building `react-native` from `main`, we invoke `yarn` under
`react-native/packages/react-native-codegen` to prepare it. This also
installs dependencies, causing duplicates to appear and fails our tests.
@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS labels May 23, 2022
@tido64 tido64 requested a review from kelset May 23, 2022 08:37
@tido64 tido64 merged commit 5c9d732 into trunk May 23, 2022
@tido64 tido64 deleted the tido/fix-main-build branch May 23, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: iOS This affects iOS platform: macOS This affects macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants