Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement accessibilityLiveRegion property, and "announce" the change in rnwcpp #2124

Closed
ahimberg opened this issue Mar 5, 2019 · 2 comments
Closed

Implement accessibilityLiveRegion property, and "announce" the change in rnwcpp #2124

ahimberg opened this issue Mar 5, 2019 · 2 comments
Assignees
@jonthysell @harinikmsft @MikeHillberg
Milestone
vNext Milestone 2

Comments

@ahimberg
Copy link
Member

ahimberg commented Mar 5, 2019 •
edited by jonthysell
Loading

Android docs: https://facebook.github.io/react-native/docs/accessibility#accessibilityliveregion-android

RNW Current implementation: https://github.com/microsoft/react-native-windows/blob/master/current/ReactWindows/ReactNative/UIManager/BaseViewManager.cs#L172

accessibilityLiveRegion is just a simple accessibility property that needs be set in FrameworkElementViewManager.

The "announce" is just raising the right event, which we should do with something similar to the rnw current: https://github.com/microsoft/react-native-windows/blob/master/current/ReactWindows/ReactNative/Accessibility/AccessibilityHelper.cs#L370
@ahimberg ahimberg added the rnwcpp label Mar 5, 2019
@ahimberg ahimberg self-assigned this Mar 5, 2019
@harinikmsft harinikmsft added this to the RNWCPP Milestone 2 milestone Mar 21, 2019
@kmelmon
Copy link
Contributor

kmelmon commented Apr 22, 2019

We may able to copy the C# implementation for this

@kmelmon kmelmon assigned jonthysell and MikeHillberg and unassigned ahimberg Apr 22, 2019
@kmelmon kmelmon added Needs: PM Design New feature or request and removed ready for dev labels Apr 22, 2019
@harinikmsft harinikmsft assigned harinikmsft and unassigned YuliKl May 22, 2019
@jonthysell
Copy link
Contributor

This seems pretty straight-forward, updating the description with what the C# implementation does.

@jonthysell jonthysell added ready for dev and removed Needs: PM Design New feature or request labels May 31, 2019
@jonthysell jonthysell changed the title add accessibilityLiveRegion, announce in rnwcpp Implement accessibilityLiveRegion, announce in rnwcpp Jun 5, 2019
@jonthysell jonthysell changed the title Implement accessibilityLiveRegion, announce in rnwcpp Implement accessibilityLiveRegion property, and "announce" the change in rnwcpp Jun 5, 2019
@jonthysell jonthysell mentioned this issue Jun 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonthysell jonthysell

@harinikmsft harinikmsft

@MikeHillberg MikeHillberg

Labels
None yet
Projects
None yet
Milestone
vNext Milestone 2
Development

No branches or pull requests
6 participants
@ahimberg @jonthysell @YuliKl @harinikmsft @MikeHillberg @kmelmon