-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate 3/18 nightly RN build. #7549
Conversation
320d9b1
to
ac5f8e0
Compare
packages/@react-native-windows/tester/src/js/utils/RNTesterList.windows.js
Show resolved
Hide resolved
Looking through the upstream commits, I think we might have a new native constant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but see comments about restoring the Windows custom DatePicker page, along with whether we need to do anything with a new native constant.
packages/@react-native-windows/tester/src/js/utils/RNTesterList.windows.js
Show resolved
Hide resolved
packages/@react-native-windows/tester/src/js/utils/RNTesterList.windows.js
Show resolved
Hide resolved
@NickGerleman Interestingly, the constant is already in
|
Ooh neat. It might have been that upstream was refining flow types to capture it. Always great to discover we don't have extra work to do 😂. |
Hello @rectified95! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
2e0213d
to
5cf4a4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signing off - are the newly discovered issues regressions on our side that we're only finding now, or regressed by this new ingestion? either way it would be good to tag them accordingly so we can track.
Commits: facebook/react-native@d477f80...cfb5b5e
Closes #7309 by pulling in the updated
MapBuffer.cpp
Closes #7289 by pulling in an update to
Yoga.cpp
Issues discovered during this integration, not necessarily caused by this batch, though still recent regressions:
#7557
#7556
#7555
#7554
Microsoft Reviewers: Open in CodeFlow