Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 3/18 nightly RN build. #7549

Merged
5 commits merged into from
Apr 9, 2021
Merged

Conversation

rectified95
Copy link
Contributor

@rectified95 rectified95 commented Apr 8, 2021

Commits: facebook/react-native@d477f80...cfb5b5e

Closes #7309 by pulling in the updated MapBuffer.cpp
Closes #7289 by pulling in an update to Yoga.cpp

Issues discovered during this integration, not necessarily caused by this batch, though still recent regressions:
#7557
#7556
#7555
#7554

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the Area: Layout label Apr 8, 2021
@rectified95 rectified95 marked this pull request as ready for review April 8, 2021 22:49
@rectified95 rectified95 requested a review from a team as a code owner April 8, 2021 22:49
@NickGerleman
Copy link
Collaborator

Looking through the upstream commits, I think we might have a new native constant localeIdentifier in NativeI18nManager. Is this something we should add?

Copy link
Collaborator

@NickGerleman NickGerleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but see comments about restoring the Windows custom DatePicker page, along with whether we need to do anything with a new native constant.

@rectified95
Copy link
Contributor Author

@NickGerleman Interestingly, the constant is already in I18nManagerModule.cpp

provider.Add(L"localeIdentifier", locale);

@NickGerleman
Copy link
Collaborator

@NickGerleman Interestingly, the constant is already in I18nManagerModule.cpp

provider.Add(L"localeIdentifier", locale);

Ooh neat. It might have been that upstream was refining flow types to capture it. Always great to discover we don't have extra work to do 😂.

@rectified95 rectified95 added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Apr 9, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

Hello @rectified95!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@asklar asklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signing off - are the newly discovered issues regressions on our side that we're only finding now, or regressed by this new ingestion? either way it would be good to tag them accordingly so we can track.

@ghost ghost merged commit fd49630 into microsoft:master Apr 9, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Layout AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fork of MapBuffer.cpp display: none does not work as expected with position: absolute
3 participants