Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-expanding TextInput broken as of #966 #983

Closed
rozele opened this issue Feb 8, 2017 · 2 comments
Closed

Auto-expanding TextInput broken as of #966 #983

rozele opened this issue Feb 8, 2017 · 2 comments

Comments

@rozele
Copy link
Collaborator

rozele commented Feb 8, 2017

Previously, the height was not explicitly set on the text box because it was "computed" by the text in the box. This conflicts with the ability for the user to explicitly set the height. We need a better solution that accomodates both.

@rozele rozele added ready bug and removed small labels Feb 8, 2017
@rozele rozele added this to the Core View Managers milestone Feb 8, 2017
@dlajarretie
Copy link
Contributor

facebook/react-native@481f560

According to this commit on RN, the preferred way of sizing the TextInput is by listening to the onChange event, and then setting the height explicitly.

I don't think the "auto grow" should be implemented natively, so I guess we need to have this onChange event returning some layout info.

@rozele
Copy link
Collaborator Author

rozele commented Nov 10, 2017

Closing, this is basically a dupe of #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants