Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Add accessible Prop Functionality to Remove/Add Elements from Content Tree #11719

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

chiaramooney
Copy link
Contributor

@chiaramooney chiaramooney commented Jun 7, 2023

Description

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

Move closer to accessibility baseline on Fabric.

What

Add accessible prop functionality to Fabric. When an element sets accessible to false, the element should be removed from the UIA tree. When an element sets accessible to true, the element should exist in the UIA tree unless accessibilityRole="none".

Testing

Focusable Accessible accessibilityRole="none" Result
T T F Element can gain focus and is in the UIA tree.
T T T Element can gain focus, but is not in the UIA tree. Yellow box error should be thrown.
T F F Element can gain keyboard focus, but is not in UIA tree. Yellow box error should be thrown.
T F T Element can gain keyboard focus, but is not in UIA tree. Yellow box error should be thrown.
F T F Element cannot gain keyboard focus, but is in the UIA tree.
F T T Element cannot gain keyboard focus, but is not in the UIA tree.
F F F All properties false. Element cannot gain focus and is not in the UIA tree.
F F T All properties false. Element cannot gain focus and is not in the UIA tree.
Microsoft Reviewers: Open in CodeFlow

pRetVal->vt = VT_BOOL;
pRetVal->boolVal = props->accessible ? VARIANT_TRUE : VARIANT_FALSE;
break;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to consider if the role is accessibilityRole "none" too

@chiaramooney chiaramooney marked this pull request as ready for review June 8, 2023 18:16
@chiaramooney chiaramooney requested a review from a team as a code owner June 8, 2023 18:16
@jonthysell jonthysell added Area: Accessibility Area: Fabric Support Facebook Fabric labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Accessibility Area: Fabric Support Facebook Fabric New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants