Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View component parity for Fabric #11136

Closed
139 of 150 tasks
Tracked by #11135
jonthysell opened this issue Jan 26, 2023 · 1 comment
Closed
139 of 150 tasks
Tracked by #11135

View component parity for Fabric #11136

jonthysell opened this issue Jan 26, 2023 · 1 comment
Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: View Style Props https://reactnative.dev/docs/view-style-props Area: View Deliverable Major item tracked for top-level planning in ADO enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper
Milestone
Backlog

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Jan 26, 2023 •
edited by danielayala94
Loading

This task captures the work to reach parity between Paper and Fabric for the native code for the <View> component.

ComponentView

  1. Create the CompositionViewComponentView (CVCV)
  2. Register the ComponentView in the ComponentViewRegistry

APIs

See latest spec at https://reactnative.dev/docs/view.

View Props

53/61

API Platform RNW Paper RNW Fabric Notes
  • accessibilityActions
 FEVM Pri 2
  • accessibilityElementsHidden
 iOS No No?
  • accessibilityHint
 FEVM CBCV+CDAP Fabric: #12036
  • accessibilityIgnoresInvertColors
 iOS No No?
  • accessibilityLabel
 FEVM CBCV+CDAP Fabric: #11674
  • accessibilityLanguage
 iOS No No?
  • accessibilityLiveRegion
 Android FEVM Pri 2
  • accessibilityRole
 FEVM CDAP Fabric: #11412
  • accessibilityState
 FEVM CBCV+CDAP Fabric: Partial impl in #11674
  • accessibilityValue
 FEVM CBCV+CDAP Fabric: #12287
  • accessibilityViewIsModal
 iOS No No?
  • accessible
 VVM+FEVM CBCV+CDAP Fabric: #11719
  • collapsable
 Android No No?
  • focusable
 Android VVM CBCV+CDAP Fabric: #11674
  • hitSlop
 JS JS
  • importantForAccessibility
 Android No No?
  • nativeId
 No No?
  • needsOffscreenAlphaCompositing
 No No?
  • nextFocusDown
 Android No No?
  • nextFocusForward
 Android No No?
  • nextFocusLeft
 Android No No?
  • nextFocusRight
 Android No No?
  • nextFocusUp
 Android No No?
  • onAccessibilityAction
 VVM+VMB Pri 2
  • onAccessibilityEscape
 iOS No No?
  • onAccessibilityTap
 VVM CDAP Fabric: #11874
  • onLayout
 VMB+NUIM Pri 1
  • onMagicTap
 iOS No No?
  • onMoveShouldSetResponder
 JS JS
  • onMoveShouldSetResponderCapture
 JS JS
  • onResponderGrant
 JS JS
  • onResponderMove
 JS JS
  • onResponderReject
 JS JS
  • onResponderRelease
 JS JS
  • onResponderTerminate
 JS JS
  • onResponderTerminationRequest
 JS JS
  • onStartShouldSetResponder
 JS JS
  • onStartShouldSetResponderCapture
 JS JS
  • pointerEvents
 VMB CVCV
  • removeClippedSubviews
 No No?
  • renderToHardwareTextureAndroid
 Android No No?
  • shouldRasterizeIOS
 iOS No No?
  • style
 See Below See Below Supports View Style Props, Layout Props, Shadow Props
  • testID
 FEVM CDAP Fabric: #11412
  • accessibilityPosInSet
 Windows FEVM Pri 2
  • accessibilitySetSize
 Windows FEVM Pri 2
  • enableFocusRing
 Windows VVM CBCV+CVCV Fabric: #11323, Focus ring impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • keyDownEvents
 Windows VMB CBCV Fabric: #12146
  • keyUpEvents
 Windows VMB CBCV Fabric: #12146
  • onBlur
 Windows VVM+VMB CBCV Fabric: #11276
  • onClick
 Windows VVM Pri 1
  • onFocus
 Windows VVM+VMB CBCV Fabric: #11276
  • onKeyDown
 Windows VMB CBCV+CEH Fabric: #12146
  • onKeyDownCapture
 Windows VMB Pri 1
  • onKeyUp
 Windows VMB CBCV+CEH Fabric: #12146
  • onKeyUpCapture
 Windows VMB Pri 1
  • onMouseEnter
 Windows VVM+VMB CEH
  • onMouseLeave
 Windows VVM+VMB CEH
  • tabIndex
 Windows VVM Pri 1
  • tooltip
 Windows FEVM Pri 1

30/30

View Style Props

API Platform RNW Paper RNW Fabric Notes
  • backfaceVisibility
 No CBCV+CVCV Fabric: #11608, #12115 Impl in CBCV and CV must call updateTransformProps
  • backgroundColor
 VVM CVCV
  • borderBottomColor
 No CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderBottomEndRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderBottomLeftRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderBottomRightRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderBottomStartRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderBottomWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderColor
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderEndColor
 No CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderEndWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderLeftColor
 No CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderLeftWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderRightColor
 No CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderRightWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderStartColor
 No CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderStartWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
No CBCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderTopColor
 No CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderTopEndRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderTopLeftRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderTopRightRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderTopStartRadius
 VVM CBCV+CVCV Fabric: Border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderTopWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • elevation
 Android No No?
  • opacity
 FEVM CVCV
  • transform
 FEVM CBCV+CVCV Fabric: #12115 Impl in CBCV and CV must call updateTransformProps

52/54

Layout Props

API Platform RNW Paper RNW Fabric Notes
  • alignContent
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • alignItems
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • alignSelf
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • aspectRatio
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • borderBottomWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderEndWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderLeftWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderRightWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderStartWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderTopWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • borderWidth
 VVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics, but border impl in CBCV and CV must call updateBorderProps / updateBorderLayoutMetrics
  • bottom
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • direction
 FEVM+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • display
 FEVM+NUIM CVCV
  • end
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • flex
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • flexBasis
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • flexDirection
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • flexGrow
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • flexShrink
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • flexWrap
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • height
 VMB+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • justifyContent
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • left
 VMB+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • margin
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • marginBottom
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • marginEnd
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • marginHorizontal
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • marginLeft
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • marginRight
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • marginStart
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • marginTop
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • marginVertical
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • maxHeight
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • maxWidth
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • minHeight
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • minWidth
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • overflow
 VVM+NUIM Pri 1
  • padding
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • paddingBottom
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • paddingEnd
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • paddingHorizontal
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • paddingLeft
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • paddingRight
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • paddingStart
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • paddingTop
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • paddingVertical
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • position
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • right
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • start
 NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • top
 VMB+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • width
 VMB+NUIM CBCV+CVCV Fabric: RN Core resolves LayoutMetrics
  • zIndex
 FEVM Pri 1

4/4

Shadow Props

API Platform RNW Paper RNW Fabric Notes
  • shadowColor
 No CBCV+CVCV Fabric: #12108, Shadow props impl in CBCV and CV must call updateShadowProps
  • shadowOffset
 iOS No CBCV+CVCV Fabric: #12108, Shadow props impl in CBCV and CV must call updateShadowProps
  • shadowOpacity
 iOS No CBCV+CVCV Fabric: #12108, Shadow props impl in CBCV and CV must call updateShadowProps
  • shadowRadius
 iOS No CBCV+CVCV Fabric: #12108, Shadow props impl in CBCV and CV must call updateShadowProps

2/2

Native Component Methods

API Platform RNW Paper RNW Fabric Notes
  • blur()
 VVM+VMB CBCV Fabric: #11323
  • focus()
 VVM+VMB CBCV Fabric: #11323

Glossary

See the Glossary to decode the abbreviations above and/or the RNW Fabric Inventory.xlsx.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 26, 2023
@jonthysell jonthysell added the Area: Fabric Support Facebook Fabric label Jan 26, 2023
@jonthysell jonthysell mentioned this issue Jan 26, 2023
Closed
9 tasks
@chrisglein chrisglein added Area: View Managers Area: View Style Props https://reactnative.dev/docs/view-style-props Deliverable Major item tracked for top-level planning in ADO and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jan 30, 2023
@chrisglein chrisglein added this to the 0.73 milestone Jan 30, 2023
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Jan 30, 2023
@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jan 31, 2023
This was referenced May 3, 2023
Open
Closed
@chrisglein chrisglein mentioned this issue Aug 17, 2023
Open
This was referenced Sep 7, 2023
Closed
Closed
@chrisglein chrisglein modified the milestones: 0.73, Backlog Dec 6, 2023
@jonthysell jonthysell added New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Area: Component Views Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper Area: View API: Completion and removed Area: View Managers labels Mar 7, 2024
@jonthysell
Copy link
Contributor Author

Closing this deliverable, all remaining component properties required for parity are now being tracked by individual issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: View Style Props https://reactnative.dev/docs/view-style-props Area: View Deliverable Major item tracked for top-level planning in ADO enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper
Projects
RNW New Architecture
Status: Done
Milestone
Backlog
Development

No branches or pull requests
2 participants
@jonthysell @chrisglein