[Fabric] Add accessibilityHint support to UIA tree #12036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into YajurG-fabric-accessibilityValue
chiaramooney
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Looks good to me! Thanks for the testing screenshots. I would ping @FalseLobster to sign off as well!
chrisglein
reviewed
Aug 18, 2023
Comment on lines
+29
to
+30
| "requested": "[2.7.0-prerelease.210913003, )", | ||
| "resolved": "2.7.0-prerelease.210913003", |
There was a problem hiding this comment.
Why is this change generating impact to the lock file? It doesn't seem like it should be part of this PR.
There was a problem hiding this comment.
I had pulled from main into my branch - it may have been from that after running yarn as I was getting some errors locally after doing a rebase to remove some other commits that had unintentionally been included.
FalseLobster
approved these changes
Aug 22, 2023
YajurG
added a commit
that referenced
this pull request
Aug 22, 2023
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Add accessibilityHint support and information to UIA Tree HelpText property for improved accessibility information.
What
Added code to update HelpText UIA field with property value passed in to the accessibilityHint prop. Previously, when the accessibilityHint prop was populated, the HelpText field in the UIA tree would remain empty.
Screenshots
Before:
After:
As can be seen the HelpText property is updated within the UIA tree when setting the accessibilityHint prop
Testing
Tested that HelpText UIA field is not populated when accessibilityHint is set before code change, and that HelpText UIA field is populated after code change. Used
accessible.tsxsample page in playground for testingMicrosoft Reviewers: Open in CodeFlow