Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] update: show only cobuild build steps in the build timeline #4667

Merged
merged 4 commits into from
May 1, 2024
Merged

[rush] update: show only cobuild build steps in the build timeline #4667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fde5e70
update: show only cobuild build steps in the build timeline
aramissennyeydd Apr 26, 2024
d68cbb7
Merge remote-tracking branch 'upstream/main' into sennyeya/fix-cobuil…
aramissennyeydd Apr 29, 2024
bedd947
add changeset
aramissennyeydd Apr 29, 2024
030c7a7
only show symbol when symbol is set
aramissennyeydd Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/sennyeya-fix-cobuild-symbols_2024-04-29-16-45.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Timeline view will now only show terminal build statuses as cobuilt, all other statuses will reflect their original icons.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
9 changes: 8 additions & 1 deletion libraries/rush-lib/src/logic/operations/ConsoleTimelinePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ const TIMELINE_CHART_SYMBOLS: Record<OperationStatus, string> = {
[OperationStatus.NoOp]: '%'
};

const COBUILD_REPORTABLE_STATUSES: Set<OperationStatus> = new Set([
OperationStatus.Success,
OperationStatus.SuccessWithWarning,
OperationStatus.Failure,
OperationStatus.Blocked
]);

/**
* Timeline - colorizer for each operation status
*/
Expand Down Expand Up @@ -232,7 +239,7 @@ export function _printTimeline({ terminal, result, cobuildConfiguration }: IPrin

function getChartSymbol(record: ITimelineRecord): string {
const { isExecuteByOtherCobuildRunner, status } = record;
if (isExecuteByOtherCobuildRunner) {
if (isExecuteByOtherCobuildRunner && COBUILD_REPORTABLE_STATUSES.has(status)) {
hasCobuildSymbol = true;
aramissennyeydd marked this conversation as resolved.
Show resolved Hide resolved
return 'C';
}
Expand Down
Loading