Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FxCop SarifSdkTest is disabled, and fails when enabled. #1575

Closed
ghost opened this issue Jul 12, 2019 · 0 comments
Closed

FxCop SarifSdkTest is disabled, and fails when enabled. #1575

ghost opened this issue Jul 12, 2019 · 0 comments
Labels
area-test Issues for improving the tests and adding new ones. bug m156 resolved-fixed

Comments

@ghost
Copy link

ghost commented Jul 12, 2019

While fixing #1570, I noticed that after I caused the FxCop converter to emit run.logicalLocations, it didn't cause any tests to fail. It seems that there were no FxCop xml files with logical location information. How was that possible?

It turned out that there was one such file, SarifSdkTest.xml. But its corresponding expected output file SarifSdkTest.xml.sarif did contain run.logicalLocations, even though the converter wasn't emitting it. Therefore that file must have been created at a time when the converter did emit run.logicalLocations, and there was a subsequent regression where that functionality was lost.

Ok, fine, so why was the test passing before I made the fix?

It's because the test wasn't running, and that's because, even though the project file copied the expected output file to the test bin directory, it did not copy the input file.

When I enable the test by adding SarifSdkTest.xml to the project file, it fails. I don't completely understand why.

@ghost ghost added bug area-test Issues for improving the tests and adding new ones. labels Jul 12, 2019
@ghost ghost added the m156 label Aug 14, 2019
@ghost ghost self-assigned this Aug 14, 2019
ghost pushed a commit that referenced this issue Aug 14, 2019
@ghost ghost closed this as completed in 464f95b Aug 15, 2019
@ghost ghost added the resolved-fixed label Aug 15, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Issues for improving the tests and adding new ones. bug m156 resolved-fixed
Projects
None yet
Development

No branches or pull requests

0 participants