Fix #1575: SarifSdkTest.xml conversion test does not run. #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
requested review from
|
@harleenkohli is added to the review. #Closed |
|
@SurbhiMS is added to the review. #Closed |
ghost
commented
Aug 14, 2019
| @@ -1 +0,0 @@ | |||
| {"$schema":"https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.4.json","version":"2.1.0","runs":[{"results":[{"ruleId":"CA0001","message":{"text":"Engine exception: Microsoft.FxCop.Sdk.InvalidMetadataException: The following error was encountered while reading module 'ManagedPlayToReceiver': Could not resolve member reference: [Windows, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null]Windows.UI.Xaml.SizeChangedEventArgs::get_PreviousSize. at Microsoft.FxCop.Sdk.Reader.HandleError(ModuleNode mod, String errorMessage) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1048\n at Microsoft.FxCop.Sdk.Reader.GetMemberFromRef(Int32 i, TypeNodeCollection& varArgTypes, Int32 numGenericArgs) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 2408\n at Microsoft.FxCop.Sdk.Reader.GetMemberFromToken(Int32 tok, TypeNodeCollection& varArgTypes) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 2200\n at Microsoft.FxCop.Sdk.InstructionParser.ParseInstruction() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\InstructionParser.cs:line 274\n at Microsoft.FxCop.Sdk.InstructionParser.ParseInstructions() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\InstructionParser.cs:line 136\n at Microsoft.FxCop.Sdk.Reader.ParseMethodInstructions(Method method, Int32 methodIndex, Int32 RVA) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 3500\n at Microsoft.FxCop.Sdk.Reader.GetMethodInstructions(Method method, Object i) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1973\n at Microsoft.FxCop.Sdk.Reader.GetMethodBody(Method method, Object i, Boolean asInstructionList) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1910\n at Microsoft.FxCop.Sdk.Method.get_Instructions() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Nodes\\Method.cs:line 251\n at Microsoft.FxCop.Sdk.RuleUtilities.HasImperativeSecurityAction(Method method, SecurityAction action) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\SDK\\RuleUtilities.cs:line 923\n at Microsoft.FxCop.Sdk.RuleUtilities.HasSecurityAction(Method method, SecurityAction action) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\SDK\\RuleUtilities.cs:line 870\n at Microsoft.FxCop.Sdk.RuleUtilities.HasSecurityAction(Method method, SecurityAction[] actions) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\SDK\\RuleUtilities.cs:line 880\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.RecordCallSites(Method caller) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 466\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.VisitMember(Member member, TargetMember target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 434\n at Microsoft.FxCop.Engines.Introspection.BaseVisitor.VisitMembers(MemberCollection members, TargetMemberDictionary targets, Boolean visitNestedTypes) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\BaseVisitor.cs:line 184\n at Microsoft.FxCop.Engines.Introspection.BaseVisitor.VisitType(TypeNode type, TargetType target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\BaseVisitor.cs:line 72\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.VisitType(TypeNode type, TargetType target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 417\n at Microsoft.FxCop.Engines.Introspection.BaseVisitor.VisitTypes(TypeNodeCollection types, TargetNamespaceDictionary targets) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\BaseVisitor.cs:line 131\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.VisitModule(ModuleNode module, TargetModule target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 394\n at Microsoft.FxCop.Engines.Introspection.BaseVisitor.VisitAssembly(AssemblyNode assembly, TargetFile target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\BaseVisitor.cs:line 37\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.VisitAssembly(AssemblyNode assembly, TargetFile target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 356\n at Microsoft.FxCop.Engines.Introspection.LoadVisitor.Load(TargetFile target, Boolean buildTree, Boolean queueItems, AssemblyNode loadedAssembly) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 179\n at Microsoft.FxCop.Engines.Introspection.LoadVisittor.LoadAssemblies(Queue queue, ExceptionCollection exceptions) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\LoadVisitor.cs:line 103."},"locations":[{}],"partialFingerprints":{"UniqueId":"Microsoft.FxCop.Sdk.InvalidMetadataException"}},{"ruleId":"CA0001","message":{"text":"Rule CA2001 exception: Microsoft.FxCop.Sdk.InvalidMetadataException: The following error was encountered while reading module 'ManagedPlayToReceiver': Could not resolve member reference: [Windows, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null]Windows.UI.Xaml.SizeChangedEventArgs::get_PreviousSize. at Microsoft.FxCop.Sdk.Reader.HandleError(ModuleNode mod, String errorMessage) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1048\n at Microsoft.FxCop.Sdk.Reader.GetMemberFromRef(Int32 i, TypeNodeCollection& varArgTypes, Int32 numGenericArgs) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 2408\n at Microsoft.FxCop.Sdk.Reader.GetMemberFromToken(Int32 tok, TypeNodeCollection& varArgTypes) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 2200\n at Microsoft.FxCop.Sdk.InstructionParser.ParseInstruction() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\InstructionParser.cs:line 274\n at Microsoft.FxCop.Sdk.InstructionParser.ParseInstructions() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\InstructionParser.cs:line 136\n at Microsoft.FxCop.Sdk.Reader.ParseMethodInstructions(Method method, Int32 methodIndex, Int32 RVA) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 3500\n at Microsoft.FxCop.Sdk.Reader.GetMethodInstructions(Method method, Object i) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1973\n at Microsoft.FxCop.Sdk.Reader.GetMethodBody(Method method, Object i, Boolean asInstructionList) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Reader\\Reader.cs:line 1910\n at Microsoft.FxCop.Sdk.Method.get_Instructions() in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\BinaryReader\\Nodes\\Method.cs:line 251\n at Microsoft.FxCop.Rules.Reliability.AvoidCallingProblematicMethods.Check(Member member) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Rules\\Reliability\\AvoidCallingProblematicMethods.cs:line 76\n at Microsoft.FxCop.Engines.Introspection.AnalysisVisitor.CheckMember(Member memberToAnalyze, Member member, TargetMember target) in d:\\design\\src\\edev\\StaticAnalysis\\FxCop\\Source\\Engines\\Introspection\\AnalysisVisitor.cs:line 492."},"locations":[{}],"partialFingerprints":{"UniqueId":"ManagedPlayToReceiver.PlayToReceiverPage.#ImgPlayer_SizeChanged(System.Object,Windows.UI.Xaml.SizeChangedEventArgs)#Microsoft.FxCop.Sdk.InvalidMetadataException"}}],"tool":{"driver":{"name":"FxCop"}},"columnKind":"utf16CodeUnits"}]} | |||
There was a problem hiding this comment.
$schema [](start = 2, length = 7)
File inadvertently committed in a previous PR. #Resolved
|
@rtaket is added to the review. #Closed |
|
@cfaucon is added to the review. #Closed |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the project file to include SarifSdkTest.xml in the FxCop conversion unit tests. The corresponding .xml.sarif file was already valid, except for a message string that we recently changed. I don't know why, at the time #1575 was filed, the test would fail if you enabled it.