CC: Message bar is in wrong location #1684
Assignees
Labels
sk team issue
A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Comments
matthewbolanos
added
copilot chat
sk team issue
5 tasks
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 7, 2023
### Motivation and Context This change is meant to fix some of the UI bugs in Copilot chat. Most of the changes are localized to just the header and chat list areas of the application to fix font weights, line heights, spacing, and colors. - #1679 - #1680 - #1681 - #1682 - #1684 - #1683 ### Description This change update many of the hardcoded values in the GriffelStyle objects to use Fluent UI tokens instead. Additionally, instead of special values for the brand colors, I added a brand ramp for Semantic Kernel so that the brand colors correctly flowed through all of the components. **Before** <img width="1416" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/1409190/f0a6ab1b-860b-421c-a6bc-5c6d9305e816"> **After** <img width="1416" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/1409190/55eea26f-a92f-4189-8fd2-6ffdd1979088"> ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
alliscode
pushed a commit
to microsoft/chat-copilot
that referenced
this issue
Jul 19, 2023
### Motivation and Context This change is meant to fix some of the UI bugs in Copilot chat. Most of the changes are localized to just the header and chat list areas of the application to fix font weights, line heights, spacing, and colors. - microsoft/semantic-kernel#1679 - microsoft/semantic-kernel#1680 - microsoft/semantic-kernel#1681 - microsoft/semantic-kernel#1682 - microsoft/semantic-kernel#1684 - microsoft/semantic-kernel#1683 ### Description This change update many of the hardcoded values in the GriffelStyle objects to use Fluent UI tokens instead. Additionally, instead of special values for the brand colors, I added a brand ramp for Semantic Kernel so that the brand colors correctly flowed through all of the components. **Before** <img width="1416" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/1409190/f0a6ab1b-860b-421c-a6bc-5c6d9305e816"> **After** <img width="1416" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/1409190/55eea26f-a92f-4189-8fd2-6ffdd1979088"> ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Message bar should be here instead
The text was updated successfully, but these errors were encountered: