Copilot Chat: Fix header and chat list UI bugs #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 22, 2023
TaoChenOSU
reviewed
Jun 26, 2023
samples/apps/copilot-chat-app/webapp/src/components/chat/chat-list/NewBotMenu.tsx
Show resolved
Hide resolved
dehoward
reviewed
Jun 27, 2023
|
This PR also fixes #1740 |
dehoward
previously approved these changes
Jun 29, 2023
shawncal
changed the title
gitri-ms
previously approved these changes
Jul 7, 2023
gitri-ms
approved these changes
Jul 7, 2023
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context This change is meant to fix some of the UI bugs in Copilot chat. Most of the changes are localized to just the header and chat list areas of the application to fix font weights, line heights, spacing, and colors. - microsoft#1679 - microsoft#1680 - microsoft#1681 - microsoft#1682 - microsoft#1684 - microsoft#1683 ### Description This change update many of the hardcoded values in the GriffelStyle objects to use Fluent UI tokens instead. Additionally, instead of special values for the brand colors, I added a brand ramp for Semantic Kernel so that the brand colors correctly flowed through all of the components. **Before** <img width="1416" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/1409190/f0a6ab1b-860b-421c-a6bc-5c6d9305e816"> **After** <img width="1416" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/1409190/55eea26f-a92f-4189-8fd2-6ffdd1979088"> ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 馃槃 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change is meant to fix some of the UI bugs in Copilot chat. Most of the changes are localized to just the header and chat list areas of the application to fix font weights, line heights, spacing, and colors.
Description
This change update many of the hardcoded values in the GriffelStyle objects to use Fluent UI tokens instead. Additionally, instead of special values for the brand colors, I added a brand ramp for Semantic Kernel so that the brand colors correctly flowed through all of the components.
Before
After
Contribution Checklist
dotnet format