Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC: Conversation actions are stacked on top of each other #1679

Closed
matthewbolanos opened this issue Jun 22, 2023 · 0 comments · Fixed by #1685
Closed

CC: Conversation actions are stacked on top of each other #1679

matthewbolanos opened this issue Jun 22, 2023 · 0 comments · Fixed by #1685
Assignees
@matthewbolanos
Labels
sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@matthewbolanos
Copy link
Member

The UX currently looks like this

Image

It should look like this

Image
@matthewbolanos matthewbolanos self-assigned this Jun 22, 2023
@matthewbolanos matthewbolanos added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) ui bug labels Jun 22, 2023
@matthewbolanos matthewbolanos mentioned this issue Jun 22, 2023
Merged
5 tasks
@matthewbolanos matthewbolanos linked a pull request Jun 22, 2023 that will close this issue
Copilot Chat: Fix header and chat list UI bugs #1685
Merged
5 tasks
@matthewbolanos matthewbolanos changed the title CC: Conversation actions are stacked on top of each other [ui bug] CC: Conversation actions are stacked on top of each other Jun 22, 2023
github-merge-queue bot pushed a commit that referenced this issue Jul 7, 2023
@matthewbolanos @gitri-ms
Copilot Chat: Fix header and chat list UI bugs (#1685)
99d5bd9 
### Motivation and Context
This change is meant to fix some of the UI bugs in Copilot chat. Most of
the changes are localized to just the header and chat list areas of the
application to fix font weights, line heights, spacing, and colors.

- #1679
- #1680
- #1681
- #1682
- #1684
- #1683

### Description
This change update many of the hardcoded values in the GriffelStyle
objects to use Fluent UI tokens instead. Additionally, instead of
special values for the brand colors, I added a brand ramp for Semantic
Kernel so that the brand colors correctly flowed through all of the
components.

**Before**
<img width="1416" alt="image"
src="https://github.com/microsoft/semantic-kernel/assets/1409190/f0a6ab1b-860b-421c-a6bc-5c6d9305e816">

**After**
<img width="1416" alt="image"
src="https://github.com/microsoft/semantic-kernel/assets/1409190/55eea26f-a92f-4189-8fd2-6ffdd1979088">

### Contribution Checklist
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
alliscode pushed a commit to microsoft/chat-copilot that referenced this issue Jul 19, 2023
@matthewbolanos @gitri-ms
Copilot Chat: Fix header and chat list UI bugs (#1685)
76a5d24 
### Motivation and Context
This change is meant to fix some of the UI bugs in Copilot chat. Most of
the changes are localized to just the header and chat list areas of the
application to fix font weights, line heights, spacing, and colors.

- microsoft/semantic-kernel#1679
- microsoft/semantic-kernel#1680
- microsoft/semantic-kernel#1681
- microsoft/semantic-kernel#1682
- microsoft/semantic-kernel#1684
- microsoft/semantic-kernel#1683

### Description
This change update many of the hardcoded values in the GriffelStyle
objects to use Fluent UI tokens instead. Additionally, instead of
special values for the brand colors, I added a brand ramp for Semantic
Kernel so that the brand colors correctly flowed through all of the
components.

**Before**
<img width="1416" alt="image"
src="https://github.com/microsoft/semantic-kernel/assets/1409190/f0a6ab1b-860b-421c-a6bc-5c6d9305e816">

**After**
<img width="1416" alt="image"
src="https://github.com/microsoft/semantic-kernel/assets/1409190/55eea26f-a92f-4189-8fd2-6ffdd1979088">

### Contribution Checklist
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewbolanos matthewbolanos

Labels
sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copilot Chat: Fix header and chat list UI bugs matthewbolanos/semantic-kernel
1 participant
@matthewbolanos