.Net & Python: Fix Broken Links #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c_kernel/planners/plan.py
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
github-actions
bot
changed the title
justindhillon
changed the title
…t-versions/get-secret-versions
Fix for an apparent find/replace error in the Agent instruction string. Minor typo. ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Small fix to use the correct configuration for the deployment name in the DALL-E example.
### Motivation and Context Reduce the burden on developers who want to use SK experimental features by reducing the number of `SKEXP` flags to the following list: | SKEXP | Experimental Features Category | |-------|--------------------------------| | SKEXP0001 | Semantic Kernel core | | SKEXP0010 | OpenAI and Azure OpenAI services | | SKEXP0020 | Memory abstractions | | SKEXP0040 | Function types | | SKEXP0050 | Out-of-the-box plugins | | SKEXP0060 | Planners | | SKEXP0070 | AI connectors | | SKEXP0100 | Advanced Semantic Kernel features | ### Description Closes microsoft#5242 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fix microsoft#5337 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Improved openai connector compatibility. When the user message has only one TextContent, serialize the user message as a string. Otherwise, serialize the user message as an array. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com>
…ft#5197) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
…ns in the kernel (microsoft#5417) ### Motivation and Context In a previous fix, the error -> exception key change was missed in a line in the kernel. This fixes that. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description This PR: - fixes the incorrect key (error) and now pulls the exception from the metadata for streaming invoke for the key `exception`. Closes microsoft#5385 - Adds a unit test <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
…osoft#5418) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> adds a __init__ file to the prompt_template folder which exposes the most important classes from the files. fixes microsoft#5172 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
…c_kernel/planners/sequential_planner/Plugins/SequentialPlanning/skprompt.txt
markwallace-microsoft
added
kernel
markwallace-microsoft
removed
kernel
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
Python 3.8 Test Coverage Report •
Python 3.8 Unit Test Overview
|
Python 3.11 Test Coverage Report •
Python 3.11 Unit Test Overview
|
Python 3.9 Test Coverage Report •
Python 3.9 Unit Test Overview
|
Python 3.12 Test Coverage Report •
Python 3.12 Unit Test Overview
|
|
@moonbox3 @eavanvalkenburg Would it be possible to move code coverage reports for Python code from PR comments to CI pipeline? Posting code coverage in PR comments has some disadvantages:
For .NET code, we output code coverage in CI pipeline. It's useful when code coverage threshold is not met and you can see which assembly requires more tests. It's also possible to check code coverage for specific .NET SDK version: Maybe we can do something similar for Python? Let me know what you think, thanks! |
eavanvalkenburg
approved these changes
Mar 13, 2024
markwallace-microsoft
approved these changes
Mar 22, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Description I used [link-inspector](https://github.com/justindhillon/link-inspector) to find and fix broken links in this project. This is an updated PR of microsoft#4910, which fixes the merge conflict. Here are the links I have fixed: https://docs.microsoft.com/rest/api/keyvault/getsecrets/getsecrets --> https://learn.microsoft.com/en-us/rest/api/keyvault/secrets/get-secret/get-secret https://docs.microsoft.com/rest/api/keyvault/getkeys/getkeys --> https://learn.microsoft.com/en-us/rest/api/keyvault/keys/get-keys/get-keys https://docs.microsoft.com/rest/api/keyvault/encrypt/encrypt --> https://learn.microsoft.com/en-us/rest/api/keyvault/keys/encrypt/encrypt https://docs.microsoft.com/rest/api/keyvault/decrypt/decrypt --> https://learn.microsoft.com/en-us/rest/api/keyvault/keys/decrypt/decrypt https://docs.microsoft.com/rest/api/keyvault/createkey/createkey --> https://learn.microsoft.com/en-us/rest/api/keyvault/keys/create-key/create-key https://docs.microsoft.com/rest/api/keyvault/getsecretversions/getsecretversions --> https://learn.microsoft.com/en-us/rest/api/keyvault/secrets/get-secret-versions/get-secret-versions https://github.com/microsoft/semantic-kernel/blob/main/python/semantic_kernel/planning/plan.py --> https://github.com/microsoft/semantic-kernel/blob/main/python/semantic_kernel/planners/plan.py https://github.com/microsoft/semantic-kernel/blob/main/python/semantic_kernel/planning/sequential_planner/Plugins/SequentialPlanning/skprompt.txt --> https://github.com/microsoft/semantic-kernel/blob/main/samples/plugins/QAPlugin/Form/skprompt.txt ### Support my work These links were found with [link-inspector](https://github.com/justindhillon/link-inspector). If you find this PR useful, give the repo a ⭐ ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Stuart Morris <89403118+StuartMorrisHitachi@users.noreply.github.com> Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com> Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com> Co-authored-by: Jadyn <jadyn.wong@live.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com> Co-authored-by: Chris <66376200+crickman@users.noreply.github.com> Co-authored-by: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I used link-inspector to find and fix broken links in this project. This is an updated PR of #4910, which fixes the merge conflict. Here are the links I have fixed:
https://docs.microsoft.com/rest/api/keyvault/getsecrets/getsecrets --> https://learn.microsoft.com/en-us/rest/api/keyvault/secrets/get-secret/get-secret
https://docs.microsoft.com/rest/api/keyvault/getkeys/getkeys --> https://learn.microsoft.com/en-us/rest/api/keyvault/keys/get-keys/get-keys
https://docs.microsoft.com/rest/api/keyvault/encrypt/encrypt --> https://learn.microsoft.com/en-us/rest/api/keyvault/keys/encrypt/encrypt
https://docs.microsoft.com/rest/api/keyvault/decrypt/decrypt --> https://learn.microsoft.com/en-us/rest/api/keyvault/keys/decrypt/decrypt
https://docs.microsoft.com/rest/api/keyvault/createkey/createkey --> https://learn.microsoft.com/en-us/rest/api/keyvault/keys/create-key/create-key
https://docs.microsoft.com/rest/api/keyvault/getsecretversions/getsecretversions --> https://learn.microsoft.com/en-us/rest/api/keyvault/secrets/get-secret-versions/get-secret-versions
https://github.com/microsoft/semantic-kernel/blob/main/python/semantic_kernel/planning/plan.py --> https://github.com/microsoft/semantic-kernel/blob/main/python/semantic_kernel/planners/plan.py
https://github.com/microsoft/semantic-kernel/blob/main/python/semantic_kernel/planning/sequential_planner/Plugins/SequentialPlanning/skprompt.txt --> https://github.com/microsoft/semantic-kernel/blob/main/samples/plugins/QAPlugin/Form/skprompt.txt
Support my work
These links were found with link-inspector. If you find this PR useful, give the repo a ⭐
Contribution Checklist