Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get more tests for BatchParserWrapper and ExecutionEngine #225

Closed
abist opened this issue Feb 3, 2017 · 4 comments
Closed

Get more tests for BatchParserWrapper and ExecutionEngine #225

abist opened this issue Feb 3, 2017 · 4 comments
Assignees
Labels

Comments

@abist
Copy link
Contributor

abist commented Feb 3, 2017

Write more tests for the BatchParserWrapper class as well as the ExecutionEngine class. These classes have low code coverage in coveralls right now, and can be definitely be increased.

@abist abist added the task label Feb 3, 2017
@abist abist self-assigned this Feb 3, 2017
@coquagli
Copy link
Contributor

coquagli commented Feb 4, 2017

Maybe move this to vscode-mssql?

@abist
Copy link
Contributor Author

abist commented Feb 6, 2017

@coquagli This is supposed to be added with the BatchParserWrapper itself, so I think putting it here should be fine.

@benrr101
Copy link
Contributor

benrr101 commented Feb 6, 2017

@coquagli is right, we generally keep track of tasks in vscode-mssql. I don't personally agree with it, but if we have a convention, we should stick to it to avoid confusion.

@abist
Copy link
Contributor Author

abist commented Feb 8, 2017

@benrr101 @coquagli Sure, I'll put this in vscode-mssql.

@abist abist closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants