Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix bug - fix bug of hipBusBandwidth build #193

Merged
merged 7 commits into from
Sep 13, 2021

Conversation

yukirora
Copy link
Contributor

@yukirora yukirora commented Sep 9, 2021

Description
fix bug of hipBusBandwidth building

Major Revision

  • it failed to enter the check 'hip/samples/1_Utils/hipBusBandwidth/CMakeLists.txt' when building docker, so removed this check
  • add sb_micro_path for rocm_bandwidthTest

@yukirora yukirora requested a review from a team as a code owner September 9, 2021 07:53
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #193 (7854fff) into release/0.3 (ee5c766) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/0.3     #193   +/-   ##
============================================
  Coverage        88.49%   88.49%           
============================================
  Files               57       57           
  Lines             2808     2808           
============================================
  Hits              2485     2485           
  Misses             323      323           
Flag Coverage Δ
cpu-unit-test 74.13% <ø> (ø)
cuda-unit-test 88.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5c766...7854fff. Read the comment docs.

third_party/Makefile Outdated Show resolved Hide resolved
@cp5555 cp5555 added bug Something isn't working ROCm labels Sep 9, 2021
third_party/Makefile Outdated Show resolved Hide resolved
@cp5555 cp5555 enabled auto-merge (squash) September 13, 2021 12:21
@cp5555 cp5555 merged commit 7e48ad3 into release/0.3 Sep 13, 2021
@cp5555 cp5555 deleted the v-yujiang/hip-mem-fix branch September 13, 2021 12:34
abuccts pushed a commit that referenced this pull request Sep 24, 2021
**Description**
fix bug of hipBusBandwidth building

**Major Revision**
- it failed to enter the check 'hip/samples/1_Utils/hipBusBandwidth/CMakeLists.txt' when building docker, so removed this check
- add sb_micro_path for rocm_bandwidthTest
cp5555 pushed a commit that referenced this pull request Sep 26, 2021
**Description**

Cherry-pick  bug fixes from v0.3.0 to main.

**Major Revisions**
* Docs - Upgrade version and release note (#209)
* Benchmarks: Build Pipeline - Update rccl-test git submodule to dc1ad48 (#210)
* Benchmarks: Update - Update benchmarks in configuration file (#208)
* CI/CD - Update GitHub Action VM (#211)
* Benchmarks: Fix Bug - Fix wrong parameters for gpu-sm-copy-bw in configuration examples (#203)
* CI/CD - Fix bug in build image for push event (#205)
* Benchmark: Fix Bug - fix error message of communication-computation-overlap (#204)
* Tool: Fix bug - Fix function naming issue in system info  (#200)
* CI/CD - Push images in GitHub Action (#202)
* Bug - Fix torch.distributed command for single node (#201)
* CLI - Integrate system info for node (#199)
* Benchmarks: Code Revision - Revise CMake files for microbenchmarks. (#196)
* CI/CD - Add ROCm image build in GitHub Actions (#194)
* Bug: Fix bug - fix bug of hipBusBandwidth build (#193)
* Benchmarks: Build Pipeline - Restore rocblas build logic (#197)
* Bug: Fix Bug - Add barrier before 'destroy_process_group' in model benchmarks (#198)
* Bug - Revise 'docker run' in sb deploy (#195)
* Bug - Fix Bug : fix bug of error param operations to operation in rccl-bw of hpe config (#190)

Co-authored-by: Yuting Jiang <v-yujiang@microsoft.com>
Co-authored-by: Guoshuai Zhao <guzhao@microsoft.com>
Co-authored-by: Ziyue Yang <ziyyang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants