Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix bug - Fix function naming issue in system info #200

Merged
merged 10 commits into from
Sep 18, 2021

Conversation

yukirora
Copy link
Contributor

@yukirora yukirora commented Sep 14, 2021

Description
Fix function naming issue in system info .

Major Revision

  • fix function naming issue in system info
  • save to json file
  • add timeout for subprocess.run
  • revise error handling to print exception message

@yukirora yukirora requested a review from a team as a code owner September 14, 2021 11:03
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #200 (55f2881) into release/0.3 (9106dcf) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/0.3     #200      +/-   ##
===============================================
- Coverage        88.79%   88.76%   -0.03%     
===============================================
  Files               58       58              
  Lines             2819     2821       +2     
===============================================
+ Hits              2503     2504       +1     
- Misses             316      317       +1     
Flag Coverage Δ
cpu-unit-test 74.46% <100.00%> (-0.02%) ⬇️
cuda-unit-test 88.69% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/tools/system_info.py 100.00% <100.00%> (ø)
superbench/cli/_node_handler.py 75.00% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9106dcf...55f2881. Read the comment docs.

superbench/tools/system_info.py Outdated Show resolved Hide resolved
superbench/tools/system_info.py Outdated Show resolved Hide resolved
superbench/tools/system_info.py Outdated Show resolved Hide resolved
superbench/tools/system_info.py Outdated Show resolved Hide resolved
superbench/tools/system_info.py Outdated Show resolved Hide resolved
superbench/tools/system_info.py Outdated Show resolved Hide resolved
@cp5555 cp5555 self-requested a review September 14, 2021 13:52
@cp5555 cp5555 added bug Something isn't working tool labels Sep 14, 2021
superbench/tools/system_info.py Outdated Show resolved Hide resolved
superbench/tools/system_info.py Outdated Show resolved Hide resolved
superbench/tools/system_info.py Outdated Show resolved Hide resolved
superbench/tools/system_info.py Show resolved Hide resolved
@abuccts abuccts merged commit 2d85781 into release/0.3 Sep 18, 2021
@abuccts abuccts deleted the v-yujiang/info-fix branch September 18, 2021 05:30
abuccts pushed a commit that referenced this pull request Sep 24, 2021
**Description**
Fix function naming issue in system info.

**Major Revision**
- fix function naming issue in system info 
- save to json file
- add timeout for subprocess.run
- revise error handling to print exception message
cp5555 pushed a commit that referenced this pull request Sep 26, 2021
**Description**

Cherry-pick  bug fixes from v0.3.0 to main.

**Major Revisions**
* Docs - Upgrade version and release note (#209)
* Benchmarks: Build Pipeline - Update rccl-test git submodule to dc1ad48 (#210)
* Benchmarks: Update - Update benchmarks in configuration file (#208)
* CI/CD - Update GitHub Action VM (#211)
* Benchmarks: Fix Bug - Fix wrong parameters for gpu-sm-copy-bw in configuration examples (#203)
* CI/CD - Fix bug in build image for push event (#205)
* Benchmark: Fix Bug - fix error message of communication-computation-overlap (#204)
* Tool: Fix bug - Fix function naming issue in system info  (#200)
* CI/CD - Push images in GitHub Action (#202)
* Bug - Fix torch.distributed command for single node (#201)
* CLI - Integrate system info for node (#199)
* Benchmarks: Code Revision - Revise CMake files for microbenchmarks. (#196)
* CI/CD - Add ROCm image build in GitHub Actions (#194)
* Bug: Fix bug - fix bug of hipBusBandwidth build (#193)
* Benchmarks: Build Pipeline - Restore rocblas build logic (#197)
* Bug: Fix Bug - Add barrier before 'destroy_process_group' in model benchmarks (#198)
* Bug - Revise 'docker run' in sb deploy (#195)
* Bug - Fix Bug : fix bug of error param operations to operation in rccl-bw of hpe config (#190)

Co-authored-by: Yuting Jiang <v-yujiang@microsoft.com>
Co-authored-by: Guoshuai Zhao <guzhao@microsoft.com>
Co-authored-by: Ziyue Yang <ziyyang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants