Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - Integrate system info for node #199

Merged
merged 3 commits into from Sep 16, 2021
Merged

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Sep 14, 2021

Integrate system info for node, add sb node info command.

Add `sb node info` command.
Add unit test.
@abuccts abuccts added the CLI SuperBench CLI label Sep 14, 2021
@abuccts abuccts requested a review from a team as a code owner September 14, 2021 06:39
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #199 (4832307) into release/0.3 (ff48738) will increase coverage by 0.28%.
The diff coverage is 90.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/0.3     #199      +/-   ##
===============================================
+ Coverage        88.49%   88.78%   +0.28%     
===============================================
  Files               57       58       +1     
  Lines             2808     2818      +10     
===============================================
+ Hits              2485     2502      +17     
+ Misses             323      316       -7     
Flag Coverage Δ
cpu-unit-test 74.47% <90.00%> (+0.34%) ⬆️
cuda-unit-test 88.71% <90.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/cli/_node_handler.py 87.50% <87.50%> (ø)
superbench/cli/_commands.py 100.00% <100.00%> (ø)
superbench/tools/__init__.py 100.00% <0.00%> (+100.00%) ⬆️
superbench/tools/system_info.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff48738...4832307. Read the comment docs.

@cp5555 cp5555 merged commit f91f97b into release/0.3 Sep 16, 2021
@cp5555 cp5555 deleted the xiongyf/node-info-cli branch September 16, 2021 07:06
abuccts added a commit that referenced this pull request Sep 24, 2021
Integrate system info for node, add `sb node info` command.
cp5555 pushed a commit that referenced this pull request Sep 26, 2021
**Description**

Cherry-pick  bug fixes from v0.3.0 to main.

**Major Revisions**
* Docs - Upgrade version and release note (#209)
* Benchmarks: Build Pipeline - Update rccl-test git submodule to dc1ad48 (#210)
* Benchmarks: Update - Update benchmarks in configuration file (#208)
* CI/CD - Update GitHub Action VM (#211)
* Benchmarks: Fix Bug - Fix wrong parameters for gpu-sm-copy-bw in configuration examples (#203)
* CI/CD - Fix bug in build image for push event (#205)
* Benchmark: Fix Bug - fix error message of communication-computation-overlap (#204)
* Tool: Fix bug - Fix function naming issue in system info  (#200)
* CI/CD - Push images in GitHub Action (#202)
* Bug - Fix torch.distributed command for single node (#201)
* CLI - Integrate system info for node (#199)
* Benchmarks: Code Revision - Revise CMake files for microbenchmarks. (#196)
* CI/CD - Add ROCm image build in GitHub Actions (#194)
* Bug: Fix bug - fix bug of hipBusBandwidth build (#193)
* Benchmarks: Build Pipeline - Restore rocblas build logic (#197)
* Bug: Fix Bug - Add barrier before 'destroy_process_group' in model benchmarks (#198)
* Bug - Revise 'docker run' in sb deploy (#195)
* Bug - Fix Bug : fix bug of error param operations to operation in rccl-bw of hpe config (#190)

Co-authored-by: Yuting Jiang <v-yujiang@microsoft.com>
Co-authored-by: Guoshuai Zhao <guzhao@microsoft.com>
Co-authored-by: Ziyue Yang <ziyyang@microsoft.com>
@cp5555 cp5555 mentioned this pull request Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI SuperBench CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants