Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Unit tests #54

Open
24 of 35 tasks
Tracked by #953 ...
corinagum opened this issue Mar 2, 2023 · 1 comment · Fixed by #1043, #1056, #1111, #1145 or #1161
Open
24 of 35 tasks
Tracked by #953 ...

[JS] Unit tests #54

corinagum opened this issue Mar 2, 2023 · 1 comment · Fixed by #1043, #1056, #1111, #1145 or #1161
Assignees
Labels
JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label large tshirt size large (11-20 days) QoL Quality of Life
Milestone

Comments

@corinagum
Copy link
Collaborator

corinagum commented Mar 2, 2023

%age goal?
This will also depend on when we believe breaking changes will settle down

12/7 list of JS unit tests BELOW 80%

Tasks

  1. lilyydu
@corinagum corinagum added the QoL Quality of Life label Mar 2, 2023
@Stevenic Stevenic added this to the BUILD milestone Mar 6, 2023
@corinagum corinagum modified the milestones: BUILD, Ignite May 22, 2023
@corinagum corinagum assigned Stevenic and unassigned corinagum Jun 14, 2023
@corinagum corinagum self-assigned this Jul 12, 2023
corinagum added a commit that referenced this issue Aug 15, 2023
#54 
- Finish setting up nyc coverage
- All current tests are passing
Coverage report: 

![image](https://github.com/microsoft/teams-ai/assets/14900841/28cc7b0e-9e93-4dc6-a932-db95799c1bda)

---------

Co-authored-by: Corina Gum <>
corinagum added a commit that referenced this issue Aug 16, 2023
1. Resolves #424 (as a stop-gap between updates)
1. Add information for `defaultModel` in `AzureOpenAIPlannerOptions` so
users know what deployment/model name to use.
    2. This is a mitigation until #394 is resolved.
1. #54 
    1. Minor cleanup of test scripts
2. !! Add questions for discussion on `ConversationHistory`
implementation for `clear()` behavior and `replaceLastSay()`
1. (no work item) Update `dotnet/samples/README.md` for clarity

---------

Co-authored-by: Corina Gum <>
@corinagum
Copy link
Collaborator Author

80% goal

@corinagum corinagum changed the title Unit tests [JS] Unit tests Dec 8, 2023
@corinagum corinagum added the JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label label Dec 8, 2023
@corinagum corinagum reopened this Dec 11, 2023
corinagum pushed a commit that referenced this issue Dec 13, 2023
…1056)

## Linked issues

closes: #54 

## Details

Unit tests added for:

- [x]  SequenceAugmentation.ts
- [x]  DefaultAugmentation.ts

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes
@corinagum corinagum reopened this Dec 14, 2023
corinagum added a commit that referenced this issue Dec 19, 2023
…ere switched (#1081)

## Linked issues

closes: #1063
Related to: #54 

## Details

- Fixed an issue where `config/submit` and 'config/fetch` invoke names
were switched in `TaskModules.ts`
- Adds unit tests to Task Modules 
<img width="793" alt="image"
src="https://github.com/microsoft/teams-ai/assets/14900841/8a9c0894-6b5e-45a2-8e77-577fdfedec8e">

- Add unit tests for `TextDataSource.ts`
<img width="567" alt="image"
src="https://github.com/microsoft/teams-ai/assets/14900841/438373c8-1a35-4094-b14a-f91e1ea18646">

- Add unit tests for `JSONResponseParser.ts`
<img width="624" alt="image"
src="https://github.com/microsoft/teams-ai/assets/14900841/402d5001-2f4e-4ba3-927e-096b55f9d7bd">


## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

---------

Co-authored-by: Corina Gum <>
@lilyydu lilyydu reopened this Jan 10, 2024
@corinagum corinagum reopened this Jan 11, 2024
@lilyydu lilyydu reopened this Jan 16, 2024
corinagum added a commit that referenced this issue Jan 23, 2024
## Linked issues

Fixes: #1163, closes #1181
related to: #239 #54 

## Details

- Fixes MemoryFork doc strings
- Fixes TurnState doc strings
- Adds missing docs to several classes/methods
  - Adaptive Cards
  - TurnState
  - OpenAIEmbeddings
  - Azure OpenAI Client
  - testing folder
  - Layout Engine
  - System Message
  - User Input Message 
  - User Message
  - Action Response Validator
  - Default Response Validator
  - JSON Response Validator
  - Response
  - Teams Chef Bot files
- Fix `api-extractor` script to generate an updated version of
`teams-ai.api.json` -- it was very out of date
- Fix `typedoc`script to work. I did not merge in generated docs though;
we have never used the docs site and I'm not convinced we need it. But
at least the script works for if we decide to keep it.
- Move `Test____.ts` files into `packages/src/internals/testing` --
these are mini-modules used exclusively for testing, and for better
findability I decided to move them.
- Updated eslintrc for Teams Chef Bot to allow `@remarks`
- dev packages:
  - remove typedoc (unused)
  - remove unused typedoc script

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (we use
[TypeDoc](https://typedoc.org/) to document our code)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

---------

Co-authored-by: Corina Gum <>
@corinagum corinagum reopened this Feb 5, 2024
@corinagum corinagum reopened this Feb 6, 2024
@corinagum corinagum reopened this Mar 7, 2024
@singhk97 singhk97 removed their assignment Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment