Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] chore: MemoryFork and TestMemoryFork unit tests #1051

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

lilyydu
Copy link
Contributor

@lilyydu lilyydu commented Dec 11, 2023

Linked issues

closes: #1052

Details

Unit tests added for:
(100% coverage on % statements, branch, funcs, and lines).

  • MemoryFork.ts
  • TestMemoryFork.ts

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (we use TypeDoc to document our code)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@lilyydu lilyydu added the JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label label Dec 11, 2023
@singhk97 singhk97 merged commit 61490e5 into main Dec 12, 2023
7 of 8 checks passed
@singhk97 singhk97 deleted the lilyydu/memory-fork-tests branch December 12, 2023 18:10
@aacebo aacebo mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS Change/fix applies to JS. If all three, use the 'JS & dotnet & Python' label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemoryFork.ts - 🌱 Lily
3 participants