Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar rendering new lines when using Hack typeface #115

Closed
bitcrazed opened this issue Feb 16, 2018 · 8 comments
Closed

Progress bar rendering new lines when using Hack typeface #115

bitcrazed opened this issue Feb 16, 2018 · 8 comments

Comments

@bitcrazed
Copy link
Contributor

From @mrmckeb on April 17, 2017 8:10

A brief description
When running yarn install I'm seeing a new line for each update to the progress bar. This only happens when I'm not using a default Windows font (I'm using Hack).

Expected results
The progress bar should stay on one line.

Actual results (with terminal output if applicable)
capture

Your Windows build number
1703 / 15063.138 (clean install)

Steps to reproduce the error
I use this script, in a .reg.

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\TrueTypeFont]
"000"="Hack"

Then run yarn install

Obviously I could just not use a custom typeface/font, but that affects my bash usage (there are symbols that default Windows typefaces can't render).

I'm using Hack in this instance, I haven't extensively tested other non-standard fonts. https://github.com/chrissimpkins/hack

This may be related to source-foundry/Hack#246. Any help would be appreciated.

Copied from original issue: microsoft/WSL#1936

@bitcrazed
Copy link
Contributor Author

From @simonbuchan on April 17, 2017 21:56

I've seen this with most of the fonts available by default in console settings - which ones work?

As a temporary workaround with yarn 0.23, you can add --progress false to ~/.yarnrc

See also yarnpkg/yarn#2530

@bitcrazed
Copy link
Contributor Author

From @simonbuchan on April 17, 2017 22:9

Did some testing, seems fine in most fonts actually, just broken in the ones I like 😄
Seems to have bad output in "DejaVu Sans Mono" and "Monoid" (I probably still have the hacked version from https://github.com/JB-Dmitry/monoid)
It's fine in Liberation Mono, Source Code Pro, Lucida Console and Consolas, at least.

@bitcrazed
Copy link
Contributor Author

From @mrmckeb on April 17, 2017 23:41

Thank you @simonbuchan. Hopefully, there's a solution from the Windows console team soon, as I am assuming at this stage that the issue lies there?

@bitcrazed
Copy link
Contributor Author

From @zadjii-msft on April 20, 2017 16:50

@simonbuchan This looks like it's the same as #1879, but more specifically it's the bug in #1907. Basically, for some fonts, we can't get the size of all unicode characters correctly, and that can lead so strange rendering issues. Just as an example, running tmux and trying to make a vertical split (<prefix> " or split-window -v) with the Hack typeface will most definitely look wrong.

I'll leave this open as one extra node in the large graph of issues related to that bug. I don't think we have a fix planned for that anytime soon, it's a pretty tricky bug that one is.

@bitcrazed
Copy link
Contributor Author

From @mrmckeb on April 21, 2017 2:0

Thansk @zadjii-msft. Is there any way to prioritise this issue? I know it seems small, but these sorts of things are always the 'little cuts' that can make adoption a little more painful.

I'm loving using Bash on Windows on a daily basis instead of Bash on macOS, and I'm championing it with co-workers - and these (theming, styling) are the features they often ask about first.

@bitcrazed
Copy link
Contributor Author

From @simonbuchan on April 21, 2017 2:21

Just to mention here this a special case of the general bug as it causes a line-wrap that the escape codes don't know about, which implies the rendered line-wraps and the internal line-wraps (not to be confused with logical, unwrapped lines) are being computed differently.
Does it look like you can prevent the rendered line-wrap from occurring, which would close this bug?

@bitcrazed
Copy link
Contributor Author

From @mateuszlewko on April 23, 2017 20:9

Are there any powerline fonts that work perfectly with tmux? Lucida Console works great but its missing many characters that most themes use.

@bitcrazed
Copy link
Contributor Author

@mrmckeb: Thanks for filing but if a font is not encoded properly, and doesn't express its glyph metrics correctly, there's not a lot we can do to fix this issue.

We are working on a set of improvements to drastically improve Console's ability to display a MUCH larger range of characters (far more accurately) in the future, but it'll take a few releases to get there.

Your continued patience is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant