Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The info bar shows up on nonzero exit codes even with "closeOnExit": "always" #11608

Open
zadjii-msft opened this issue Oct 25, 2021 · 1 comment
Open

The info bar shows up on nonzero exit codes even with "closeOnExit": "always" #11608

zadjii-msft opened this issue Oct 25, 2021 · 1 comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

From @KalleOlaviNiemitalo in #10798 (comment)

infobar-on-closeonexit-always

This might just go away if we do #11607 first, but it might not. Tracking this separately regardless
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-2 A description (P2) labels Oct 25, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 25, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 25, 2021
@elsaco
Copy link

elsaco commented Oct 25, 2021

This is what was observed on my desktop:

  1. with only one tab opened and "closeOnExit": "always" the tab/window just disappears without the message. With more tabs opened the "Don't show again" message appears.

  2. when "closeOnExit" is set it does not add "closeOnExitInfo" to "dismissedMessages" in state.json.

  3. with both options set to "closeOnExit": "always" and "dismissedMessages": "closeOnExitInfo" when using multiple tabs the message doesn't show up anymore.

This was tested with WT ver. 1.12.2931.0.

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 29, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@j4james j4james mentioned this issue Feb 6, 2022
Closed
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @elsaco @zadjii-msft