Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevated profile doesn't open Quake terminal #12173

Open
Tracked by #8888
elsaco opened this issue Jan 15, 2022 · 2 comments
Open
Tracked by #8888

Elevated profile doesn't open Quake terminal #12173

elsaco opened this issue Jan 15, 2022 · 2 comments
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@elsaco
Copy link

elsaco commented Jan 15, 2022

Windows Terminal version

main 7061c54

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

  • add new profile and set "elevate": true
  • open new profile
  • close previous terminal window
  • open Quake terminal

Expected Behavior

  • quake mode terminal

Actual Behavior

  • no quake mode terminal window:

wt_elevate_quake_mode_not_working

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 15, 2022
@elsaco elsaco changed the title Elevated profile dosen't open Quake terminal Elevated profile doesn't open Quake terminal Jan 17, 2022
@zadjii-msft
Copy link
Member

This is likely what happened

  1. You started the terminal, and it took the win+` hotkey
  2. You started an elevated terminal. It trued to take the win+` hotkey, but found it was already bound, so it failed.
  3. You closed the unelevated Terminal. Nothing here tells the elevated Terminal to take over the keyboard shortcuts
  4. You press win+`, but no one has that key bound.

I suspect this isn't the only time we're going to hear this on this release. Not sure what a good solution is. Maybe an elevated flag to globalSummon, as a bool?, that can filter to {any window, unelevated only, elevated only}?

This would be the release to handle this, that's for sure.

@zadjii-msft zadjii-msft added Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jan 18, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.13 milestone Jan 18, 2022
@zadjii-msft zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Jan 18, 2022
@zadjii-msft zadjii-msft removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Discussion Something that requires a team discussion before we can proceed labels Jan 31, 2022
@zadjii-msft zadjii-msft removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 23, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.14, 22H1 Feb 23, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Backlog Jun 22, 2022
@User1785604260
Copy link

Coming here from #9996. I'd like to have a way to enforce that the new headless terminal from #14944 is the only thing registering the Win+` quakeMode hotkey. This is so that I can ensure quakeMode windows are always unelevated (my preference) by launching the headless terminal as unelevated.

As it currently stands, there's a race as too which terminal starts first and captures the hotkey. If I open an elevated terminal immediately on login, I can find myself locked into elevated-only quakeMode terminals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants