-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashed horizontal line (---) when using TUI tools and JetBrainsMono NF #13794
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@lhecker Does this look like the kinda thing that would have been fixed alongside the other PL fixes for atlas engine in 1.16? |
@AdalZanabria Can you please link the exact font file which works in VS Code but doesn't work in Windows Terminal? I tried this one but it works in neither application the way you describe it. I'd also need to know how you got ligatures working in the VS Code terminal. Support for it has been broken since about 2017... I've set |
I'm using that exact same one, however it seems like the box drawings aren't ligatures, since just as you mention ligatures don't work: But it still can render a continuous line: I changed the font to glorious Comic Sans MS, a font which obviously doesn't support ligatures and it can still render continuous lines just fine: While taking this screenshots and checking the integrated terminal setting, I had a finding, a setting called "Custom Gyphs" which states it draws custom glyphs for block elements and box drawing characters, this is a screenshot with it on: And this is a screenshot with it turned off: So that's what's making the magic. But when using another font such as FiraCode NF And this is the exact same font (JetBrainsMono NF) in wezterm without any custom glyphs issues: So it's not a problem with the font, it's just when both are together. |
I see... I thought the issue was with actual dashes (U+002D "-"), but those sure seems like box characters (U+2500 "─"). In that case this issue will be fixed in 1.16 when the new text renderer / AtlasEngine is enabled. The specific PR that fixed this is #13549. 1.16 will support all "block element" and "box drawing" characters as well as the classic powerline glyphs (source). |
Is it an updated version from the the one that can be used right now with |
#13549 hasn't been released yet, but will be soon. You can subscribe to that pull request to get notified once it's been released. 🙂 |
Ok, I'll do that. Thank you very much! |
This is still broken for me on the latest preview release using the font CaskaydiaCove Nerd Font |
Actually upgrading the font in addition to using the latest release fixes the issue |
Windows Terminal version
Windows Terminal 1.14.1962.0. Also tested in Windows Terminal Preview 1.15.2002.0. Both tested with AtlasEngine off and on.
Windows build number
10.0.19044.0
Other Software
Any TUI tool with horizontal lines, for example:
Steps to reproduce
Open any Terminal User Interface tool that uses horizontal lines as separators like Midnight Commander, Ranger, neofetch, etc. While using the JetBrainsMono NF font.
Expected Behavior
To horizontal lines to render as single continuous line.
The following are examples of the same font and same size in different terminals rendering with the expected behavior:
VS Code Integrated Terminal:
Wezterm:
Hyper:
Actual Behavior
Horizontal lines render dashed, as spaced - - - -
Windows Terminal:
Windows Terminal Preview:
Not sure what can be causing this since the same exact font seems to be working on other terminals just fine, I also tested other NerdFonts like FiraCode NF in both Windows Terminal and Windows Terminal Preview and it displays the horizontal lines correctly. I thought that maybe because it was .ttf instead of .otf? But I installed FiraCode NF as .ttf and it worked fine with the lines.
Again, I also tried the Atlas Engine on are off with the same result.
I also made sure to install the versions which don't state "Mono" as a sufix in the font file name since NerdFonts specify that they could cause problems rendering ligature characters in favor of monospacing them. I did the same with FiraCode NF and Fira's horizontal lines are working while Jetbrains not.
Again this is not a problem only for Midnight Commander, it happens with every TUI Tool that uses horizontal lines or special prompts like the ones used with zsh.
I downloaded the font from nerdfonts Github repository which was rebuilt yesterday, but again the same font is working fine in other terminals.
The text was updated successfully, but these errors were encountered: