Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC 12 "set cursor color" not working, in atlas engine #14533

Closed
zadjii-msft opened this issue Dec 12, 2022 · 4 comments · Fixed by #14959
Closed

OSC 12 "set cursor color" not working, in atlas engine #14533

zadjii-msft opened this issue Dec 12, 2022 · 4 comments · Fixed by #14959
Assignees
Labels
Area-AtlasEngine In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Comments

@zadjii-msft
Copy link
Member

    @DHowett @mattwojo sorry to dig this old thread up, but if I do a `printf %b '\e]12;red\a'`, should I expect the cursor color to change to red?  Using terminal preview version 1.16.2641.0, doing the above in wsl, I don't see the cursor color changing.  It retains the original color specified via the color theme in the settings.

image

Originally posted by @damnskippy in #184 (comment)

Interestingly enough, if I lock my screen (Windows-L) and unlock it the cursor has then changed its color. image

after locking and unlocking: image

I bet we don't do an invalidate of the screen.

Nah I dunno what this is. We should move this over to the Terminal repo cause I see this too. Even with the rgb: specs too.

(from MicrosoftDocs/terminal#620)

Version number unknown.

printf '\e]12;red\a Foo bar' ; sleep 3
printf '\e]12;rgb:ff/00/00\a Foo bar' ; sleep 3
@echo off
if (%1)==() (goto :usage)
if (%2)==() (goto :usage)
if (%3)==() (goto :usage)

@rem this is a literal ESC and BEL in this next line
echo �]12;rgb:%1/%2/%3goto :EOF

:usage
echo Usage: cursor-color ^<red^> ^<green^> ^<blue^>
echo     where red, green, blue are color components in hex
echo     Ex: cursor-color FF 00 FF will set the cursor to �[38;2;255;0;255mMagenta�[0m
echo:

:EOF
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 12, 2022
@zadjii-msft zadjii-msft added Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Dec 12, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 12, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Dec 12, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 12, 2022
@zadjii-msft
Copy link
Member Author

I can confirm that the cursor changes did seem to reappear after a lock/unlock of my machine! That makes me think there's still an invalidation issue. Maybe in the Atlas engine? IDK if @damnskippy was on 1.15 or 1.16

@zadjii-msft zadjii-msft added Area-AtlasEngine and removed Area-VT Virtual Terminal sequence support labels Dec 12, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Dec 12, 2022
@zadjii-msft zadjii-msft changed the title OSC 12 "set cursor color" not working OSC 12 "set cursor color" not working, in atlas engine Dec 12, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 12, 2022
@damnskippy
Copy link

Thank you for picking this up @zadjii-msft, and I'm glad/relieved this is reproducible on your end locally. I don't know how to determine the version on Atlas Engine. If there's a command or something that can be run that will produce this, I'd be happy to do so if it's of use.

@zadjii-msft
Copy link
Member Author

@damnskippy oh _ don't mean the "atlas engine version", I more just meant the Terminal version, which you can find in the About dialog. The Atlas engine was added in 1.16, but isn't in 1.15.

@damnskippy
Copy link

Oh, Terminal (Preview) version is 1.16.2641.0.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 11, 2023
@lhecker lhecker self-assigned this Jan 19, 2023
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 19, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AtlasEngine In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants