Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use synchronous APIs for AppExtensionCatalog #15255

Open
lhecker opened this issue Apr 27, 2023 · 1 comment
Open

Use synchronous APIs for AppExtensionCatalog #15255

lhecker opened this issue Apr 27, 2023 · 1 comment
Labels
Area-Quality Stability, Performance, Etc. Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@lhecker
Copy link
Member

lhecker commented Apr 27, 2023

MSFT-43215694 added IAppExtensionCatalog2::FindAll and IAppExtension3::GetPublicFolder. If they release publicly, we should use those in the settings model because extractValueFromTaskWithoutMainThreadAwait is slow, wrong and ✨pain✨ (just that one call to FindAllAsync + await is like 4% of the total startup cost). I personally wouldn't even keep the old code because of that.
@lhecker lhecker added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Quality Stability, Performance, Etc. labels Apr 27, 2023
@lhecker lhecker added this to the Up Next milestone Apr 27, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 27, 2023
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 3, 2023
@zadjii-msft
Copy link
Member

xlink #6726 is also something we need to fix in the next version of the SDK

@carlos-zamora carlos-zamora modified the milestones: Up Next, Terminal v1.23 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Quality Stability, Performance, Etc. Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

No branches or pull requests
3 participants
@lhecker @carlos-zamora @zadjii-msft