Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colortool: inconsistent color with iterm2 #59

Closed
yatli opened this issue Feb 6, 2018 · 1 comment
Closed

colortool: inconsistent color with iterm2 #59

yatli opened this issue Feb 6, 2018 · 1 comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conhost For issues in the Console codebase Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@yatli
Copy link

yatli commented Feb 6, 2018

build 16299, using colortool from e024874

Repro:

Expect:

  • same colors

Actual:

  • different colors

Comparison:
image
Note how some of the values differ subtly with the original. Especially for the grey colors. Some are swallowed in the background.

Possibly related to the color space? In iterm2 xml the rgb components are companioned with a color profile (sRGB etc.)

Also, we should parse the foreground & background colors and set them in the console.

A more drastic example:
image

This one should be due to missing background & foreground.

@zadjii-msft
Copy link
Member

This has been discussed before on #23.

Essentially, the console doesn't have a seperate "Background Color" seperate from the color table - it uses one entry of the color table as it's "background color". So if the itermcolors scheme has a different background color from the black color, then the applied scheme is going to look different. It's as close as we can get to what's in the scheme with what conhost can do.

I absolutely want to fix this, but unfortunately its a pretty massive change to the codebase that'd be hard to get signed off on.

I'm going to close this isse as a dupe of the other, and use the other one for tracking the feature.

@zadjii-msft zadjii-msft added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conhost For issues in the Console codebase labels Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Conhost For issues in the Console codebase Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants