Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Terminal v1.1.2233.0 disappears leaving all processes intact #7345

Closed
qm2k opened this issue Aug 19, 2020 · 5 comments
Closed

Windows Terminal v1.1.2233.0 disappears leaving all processes intact #7345

qm2k opened this issue Aug 19, 2020 · 5 comments
Labels
Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Severity-Crash Crashes are real bad news.

Comments

@qm2k
Copy link

qm2k commented Aug 19, 2020

Environment

Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): 1.1.2233.0

Any other software?

I'm using git bash as shell, but I don't think it's relevant.

Steps to reproduce

Keep Windows Terminal started for days with multiple tabs and some processes running inside (e.g. normal use mode).

Expected behavior

Windows Terminal not disappearing. As a workaround (since the problem may recur), if it closes it allows me to access all of my earlier started processes again after I restart the app.

Actual behavior

Windows Terminal disappears at some time while I'm not using my computer, leaving all started processes intact. When I relaunch it the Task Manager shows my previously started processes (immediate siblings only, not processes started from these processes) under the newly opened window, but the window itself only shows one default tab:
image
image

The symptoms are exactly repeating those described in #3253 that was supposed to be fixed in v0.7.3291.0

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 19, 2020
@zadjii-msft
Copy link
Member

Well that's definitely unexpected. Especially the fact that Task manager can figure out that those child processes should be re-parented to the Windows Terminal package - if the original process were truly killed and cleaned up, then you'd imagine that there'd be no way of determining that.

Does this always take multiple days to reproduce? Or is there something that you can do to trigger this behavior on demand?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels Aug 19, 2020
@qm2k
Copy link
Author

qm2k commented Aug 20, 2020

Does this always take multiple days to reproduce? Or is there something that you can do to trigger this behavior on demand?

It happened twice already. I found both corresponding windows log events. Previous time was 30/07/2020 04:27:26 and I was definitely not present at the computer. Yesterday it happened on 09:25 and I might have been present but I don't remember anything unusual (I'm using multiple desktops so it took me some time to notice that the terminal window missing). According to logs there was no windows update at the time, and automatic suspend on mains power was disabled (and I definitely did not wake the computer up, only unlocked the screen).

Here's the last event (also .xml and .evtx):

Logged: 19/08/2020 09:25:13
The program WindowsTerminal.exe version 1.1.2007.20001 stopped interacting with Windows and was closed. To see if more information about the problem is available, check the problem history in the Security and Maintenance control panel.
Process ID: 52ec
Start Time: 01d6724a7dc40bd8
Termination Time: 4294967295
Application Path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.1.2021.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Report Id: 8a097a96-a30a-4804-b26e-61e690adf68a
Faulting package full name: Microsoft.WindowsTerminal_1.1.2021.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App
Hang type: Quiesce

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 20, 2020
@qm2k
Copy link
Author

qm2k commented Aug 20, 2020

Just noticed that versions in the version I'm currently running (1.1.2233.0, also latest in Microsoft Store) and the version in the event viewer do not match. Also found the following events from WindowsUpdateClient:

Logged: 19/08/2020 09:24:30
Installation Started: Windows has started installing the following update: 9N0DX20HK701-Microsoft.WindowsTerminal

Logged: 19/08/2020 09:25:14
Installation Successful: Windows successfully installed the following update: 9N0DX20HK701-Microsoft.WindowsTerminal

There was no system update, but apparently an app update happend sometime around the crash. Looks highly suspicious.

@DHowett
Copy link
Member

DHowett commented Aug 20, 2020

We've seen an uptick in these issues very recently--about 7 days since we released the last update. I'm starting to become convinced that this is because of the update (and not the other way around.) Thanks for the info above ^

I had a colleague help me look at dumps from these hangs, and it looks like they happen predominantly when the "do you want to close all tabs?" dialog is open.

Here's my theory:

  1. The store decides there's been an update available for long enough
  2. It asks Terminal to exit nicely
  3. Terminal resists, and says "i've got tabs open -- at least let the user confirm it"
  4. With or without an answer, this looks like Terminal is another intransigent application that needs to be put down, and so it gets terminated and blamed for "hanging".

This is a place where the platform treats us like a "store-managed" application, where we're really not.

I'm tentatively closing this as a /duplicate of #6726. Thanks for following up 😄

@ghost
Copy link

ghost commented Aug 20, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Aug 20, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Aug 20, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

3 participants