Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Disclaimer" text boxes are not read in narrator #9255

Closed
zadjii-msft opened this issue Feb 23, 2021 · 6 comments
Closed

"Disclaimer" text boxes are not read in narrator #9255

zadjii-msft opened this issue Feb 23, 2021 · 6 comments
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

(not @zadjii-msft's fault, but still relevant) This text block is not read by a screen reader (same with the disclaimer in base layer). I'll file a separate issue to track this one.

Originally posted by @carlos-zamora in #9253 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 23, 2021
@zadjii-msft zadjii-msft mentioned this issue Feb 23, 2021
Merged
@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Feb 24, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 24, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.7 milestone Feb 24, 2021
@zadjii-msft
Copy link
Member Author

Tentatively thrown on 1.7 b/c I thought we were going to make sure to fix this for 1.6 stable?

@DHowett
Copy link
Member

DHowett commented Feb 24, 2021

There's no settings UI in 1.6, so there's no disclaimer to be had 😄

@zadjii-msft
Copy link
Member Author

🤦

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 26, 2021
@carlos-zamora
Copy link
Member

carlos-zamora commented Mar 2, 2021 •
edited
Loading

This is 100% a Xaml Islands issue. See microsoft/microsoft-ui-xaml#4399.

@zadjii-msft
Copy link
Member Author

(you maybe meant microsoft/microsoft-ui-xaml#4399)

@zadjii-msft zadjii-msft added the Tracking-External This bug isn't resolved, but it's following an external workitem. label Mar 2, 2021
@zadjii-msft
Copy link
Member Author

Oh would you look at that, we got rid of this page entirely! Problem solved 🤣

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
3 participants
@DHowett @carlos-zamora @zadjii-msft