Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to load font X, using font X instead?!? #9360

Closed
greggman opened this issue Mar 3, 2021 · 11 comments
Closed

Unable to load font X, using font X instead?!? #9360

greggman opened this issue Mar 3, 2021 · 11 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone
Terminal v2.0

Comments

@greggman
Copy link

greggman commented Mar 3, 2021

Environment

Windows build number: Win32NT             10.0.19042.0 Microsoft Windows NT 10.0.19042.0
Windows Terminal version (if applicable): 1.6.10571.0

Steps to reproduce

Run Windows Terminal on my machine (sorry)

Expected behavior

It runs normally

Actual behavior

It displays this nonsense message

WindowsTerminal_BGD4W2SnLW

Was working until I let the Microsoft Store upgrade it 10 minutes ago
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 3, 2021
@DHowett
Copy link
Member

DHowett commented Mar 3, 2021

HA! Sorry! That's a really funny bug. If you change the b in your config file (Jetbrains) to B (JetBrains)... does it go away?

@miniksa you may like this one

@DHowett
Copy link
Member

DHowett commented Mar 3, 2021

What seems to be happening is that we're asking the OS for a font with the wrong case, and it's saying "I couldn't find that. Found this really similar one instead" and we dutifully present that ... "error" ... to the user.

@zadjii-msft
Copy link
Member

Maybe we should relax the scenario where we display that error - if we pick one with the same (case-insensitive) name, then maybe just skip the warning.

@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 3, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 3, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Mar 3, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 3, 2021
@miniksa
Copy link
Member

miniksa commented Mar 4, 2021

I like @zadjii-msft 's idea. Just do an insensitive compare and don't show if it matches.

@skyline75489
Copy link
Collaborator

Sorry is #9157 the same as this? I think that one is also worth noticing.

@greggman
Copy link
Author

greggman commented Mar 4, 2021

It was a case issue but ... it worked before the latest update so some change took it from case insensitive to case sensitive.

@zadjii-msft
Copy link
Member

The warning was only added in 1.6 (see #8207), so that's what happened there 😉

@vibonacci
Copy link

image

Very funny.

@DHowett
Copy link
Member

DHowett commented Mar 13, 2021

Yes, that is the central thesis of this bug report. Have you tried the suggested workaround?

@eugenesmlv eugenesmlv mentioned this issue Mar 14, 2021
Closed
@ghost ghost added the In-PR This issue has a related PR label Mar 14, 2021
@DHowett DHowett mentioned this issue Mar 20, 2021
Closed
@ghost ghost removed the In-PR This issue has a related PR label Apr 7, 2021
@miniksa
Copy link
Member

miniksa commented Apr 7, 2021

/dup #9375
I will be handling this case in the PR attached to the dupe I'm linking this to.

Thanks

@ghost
Copy link

ghost commented Apr 7, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 7, 2021
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Apr 7, 2021
@zadjii-msft zadjii-msft mentioned this issue Feb 28, 2022
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Make font name comparison case-insensitive eugenesmlv/terminal
6 participants
@DHowett @greggman @skyline75489 @vibonacci @miniksa @zadjii-msft