Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert CommandHistory to a std::shared_ptr #1161

Merged
merged 5 commits into from
Jun 19, 2019
Merged

Convert CommandHistory to a std::shared_ptr #1161

merged 5 commits into from
Jun 19, 2019

Commits on Jun 7, 2019

  1. Changes for Issue microsoft#1058 are done in VS2017. Works fine.

    @ChristophePichaud
    ChristophePichaud committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    1452071 View commit details
    Browse the repository at this point in the history

  2. calculatePopupSize use a const CommandHistory& and is called from a s… 

    …hared_ptr.
    @ChristophePichaud
    ChristophePichaud committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    4e4b965 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Some shared_ptr are converted into refrences. 

    Better appropriated.
    @ChristophePichaud
    ChristophePichaud committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    3f19be4 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Add missing const stuff. 

    Remove a comment.
    @ChristophePichaud
    ChristophePichaud committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    3cd6f1b View commit details
    Browse the repository at this point in the history

  2. cookedReadData.History() returns a ref. Callers adapted. OK.

    @ChristophePichaud
    ChristophePichaud committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    e8104ed View commit details
    Browse the repository at this point in the history