-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add audit build step for code formatting check #1208
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ef4aed2
add audit build step for code formatting check
adiviness 4cb9281
adjust path to OpenConsole module
adiviness 899616c
add clang-format to dep folder
adiviness e294454
add bad formatting to test ci failing
adiviness 091eef5
fix intentional bad formatting
adiviness File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
|
||
#.SYNOPSIS | ||
# Checks for code formatting errors. Will throw exception if any are found. | ||
function Invoke-CheckBadCodeFormatting() { | ||
Import-Module ./tools/OpenConsole.psm1 | ||
Invoke-CodeFormat | ||
# returns a non-zero exit code if there are any diffs in the tracked files in the repo | ||
git diff-index --quiet HEAD -- | ||
if ($lastExitCode -eq 1) { | ||
throw "code formatting bad, run Invoke-CodeFormat on branch" | ||
} | ||
} | ||
|
||
Invoke-CheckBadCodeFormatting |
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably we can just unencapsulate this code and make it the toplevel contents of the script file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to leave it encapsulated, as a personal preference.