Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization Updates - main - associated with #16886 #17035

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Localization Updates - main - associated with #16886 #17035

merged 1 commit into from
Apr 16, 2024

Conversation

consvc
Copy link
Collaborator

@consvc consvc commented Apr 10, 2024

No description provided.

DHowett
DHowett requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting this one - I’ll give the localizations time to bake so that we can update all the strings in one future easily-cherry-pickable PR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 10, 2024
DHowett
DHowett reviewed Apr 11, 2024
View reviewed changes
src/cascadia/TerminalApp/Resources/de-DE/Resources.resw
</data>
<data name="TabCloseOther" xml:space="preserve">
<value>Andere Registerkarten schließen</value>
</data>
<data name="TabClose" xml:space="preserve">
<value>Registerkarte schließen</value>
<value>Tab schließen</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEONARD LOOK

@DHowett DHowett changed the title Localization Updates - main - 04/10/2024 03:04:11 Localization Updates - main - associated with #16886 Apr 15, 2024
@DHowett DHowett added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2024
@lhecker lhecker added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2024
@zadjii-msft zadjii-msft added this pull request to the merge queue Apr 16, 2024
@DHowett DHowett removed this pull request from the merge queue due to a manual request Apr 16, 2024
@DHowett DHowett merged commit f4d8a74 into main Apr 16, 2024
20 checks passed
@DHowett DHowett deleted the automated/loc-update branch April 16, 2024 15:36
@DHowett DHowett added this to To Cherry Pick in 1.19 Servicing Pipeline via automation Apr 16, 2024
@DHowett DHowett added this to To Cherry Pick in 1.20 Servicing Pipeline via automation Apr 16, 2024
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.20 Servicing Pipeline Apr 16, 2024
DHowett pushed a commit that referenced this pull request Apr 16, 2024
@consvc @DHowett
Localization Updates - main - associated with #16886 (#17035)
6e3fc69 
(cherry picked from commit f4d8a74)
Service-Card-Id: 92350383
Service-Version: 1.20
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.19 Servicing Pipeline Apr 16, 2024
DHowett pushed a commit that referenced this pull request Apr 16, 2024
@consvc @DHowett
Localization Updates - main - associated with #16886 (#17035)
39f9092 
(cherry picked from commit f4d8a74)
Service-Card-Id: 92350382
Service-Version: 1.19
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.20 Servicing Pipeline May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something
Projects
1.19 Servicing Pipeline
Cherry Picked
1.20 Servicing Pipeline
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@consvc @DHowett @lhecker